Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink

components/exo/compositor_frame_sink_holder.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/exo/compositor_frame_sink_holder.h"
+
+#include "cc/resources/returned_resource.h"
+#include "components/exo/surface.h"
+
+namespace exo {
+
+////////////////////////////////////////////////////////////////////////////////
+// CompositorFrameSinkHolder, public:

[reveman, 2016/12/07 00:46:57]

nit: blankline after this

[Alex Z., 2016/12/07 20:09:35]

Done.

+CompositorFrameSinkHolder::CompositorFrameSinkHolder(
+    cc::mojom::MojoCompositorFrameSinkPtr compositor_frame_sink,
+    base::WeakPtr<Surface> surface,
+    cc::mojom::MojoCompositorFrameSinkClientRequest request)
+    : compositor_frame_sink_(std::move(compositor_frame_sink)),
+      surface_(surface),
+      begin_frame_source_(base::MakeUnique<cc::ExternalBeginFrameSource>(this)),
+      binding_(this, std::move(request)) {}
+
+bool CompositorFrameSinkHolder::HasReleaseCallbacks(cc::ResourceId id) {
+  return release_callbacks_.count(id);

[reveman, 2016/12/07 00:46:57]

release_callbacks_.find(id) != release_callbacks_.end() is more efficient

[Alex Z., 2016/12/07 20:09:35]

Done.

+}
+
+bool CompositorFrameSinkHolder::IsReleaseCallbacksEmpty() {
+  return release_callbacks_.size() == 0;

[reveman, 2016/12/07 00:46:56]

release_callbacks_.empty() is easier to read

[Alex Z., 2016/12/07 20:09:35]

Done.

+}
+
+void CompositorFrameSinkHolder::AddResourceReleaseCallback(
+    cc::ResourceId id,
+    std::unique_ptr<cc::SingleReleaseCallback> callback) {
+  release_callbacks_[id] = std::make_pair(this, std::move(callback));
+}
+
+void CompositorFrameSinkHolder::ActivateFrameCallbacks(
+    std::list<FrameCallback>& frame_callbacks) {
+  active_frame_callbacks_.splice(active_frame_callbacks_.end(),
+                                 frame_callbacks);
+}
+
+void CompositorFrameSinkHolder::CancelFrameCallbacks() {
+  // Call pending frame callbacks with a null frame time to indicate that they
+  // have been cancelled.
+  for (const auto& frame_callback : active_frame_callbacks_)
+    frame_callback.Run(base::TimeTicks());
+}
+
+void CompositorFrameSinkHolder::UpdateNeedsBeginFrame() {

[reveman, 2016/12/07 00:46:56]

this is private. please move down into correct section

[Alex Z., 2016/12/07 20:09:35]

Done.

+  if (!begin_frame_source_)
+    return;
+
+  bool needs_begin_frame = !active_frame_callbacks_.empty();
+  if (needs_begin_frame == needs_begin_frame_)
+    return;
+
+  needs_begin_frame_ = needs_begin_frame;
+  OnNeedsBeginFrames(needs_begin_frame_);
+}
+
+void CompositorFrameSinkHolder::SetNeedsBeginFrame(bool needs_begin_frame) {
+  needs_begin_frame_ = needs_begin_frame;
+  OnNeedsBeginFrames(needs_begin_frame);
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// cc::mojom::MojoCompositorFrameSinkClient overrides:
+
+void CompositorFrameSinkHolder::DidReceiveCompositorFrameAck() {
+  // TODO(staraz): Implement this
+}
+
+void CompositorFrameSinkHolder::OnBeginFrame(const cc::BeginFrameArgs& args) {
+  while (!active_frame_callbacks_.empty()) {
+    active_frame_callbacks_.front().Run(args.frame_time);
+    active_frame_callbacks_.pop_front();
+  }
+  begin_frame_source_->OnBeginFrame(args);
+}
+
+void CompositorFrameSinkHolder::ReclaimResources(
+    const cc::ReturnedResourceArray& resources) {
+  scoped_refptr<CompositorFrameSinkHolder> holder(this);
+  for (auto& resource : resources) {
+    auto it = release_callbacks_.find(resource.id);
+    DCHECK(it != release_callbacks_.end());
+    it->second.second->Run(resource.sync_token, resource.lost);
+    release_callbacks_.erase(it);
+  }
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// cc::BeginFrameObserver:

[reveman, 2016/12/07 00:46:57]

nit: cc::BeginFrameObserver overrides:

[Alex Z., 2016/12/07 20:09:35]

Done.

+const cc::BeginFrameArgs& CompositorFrameSinkHolder::LastUsedBeginFrameArgs()
+    const {
+  return last_begin_frame_args_;
+}
+
+void CompositorFrameSinkHolder::OnBeginFrameSourcePausedChanged(bool paused) {}
+
+////////////////////////////////////////////////////////////////////////////////
+// ExoComopositorFrameSink, private:
+
+CompositorFrameSinkHolder::~CompositorFrameSinkHolder() {}
+
+void CompositorFrameSinkHolder::WillDrawSurface() {

[reveman, 2016/12/07 00:46:56]

this is not private. please move up to the correct section

[Alex Z., 2016/12/07 20:09:35]

Done.

+  if (surface_)
+    surface_->WillDraw();
+
+  UpdateNeedsBeginFrame();
+}
+
+////////////////////////////////////////////////////////////////////////////////

[reveman, 2016/12/07 00:46:56]

please move this up to match the new location in the header file

[Alex Z., 2016/12/07 20:09:35]

Done.

+// cc::ExternalBeginFrameSouceClient:

[reveman, 2016/12/07 00:46:56]

cc::ExternalBeginFrameSouceClient overrides:

[Alex Z., 2016/12/07 20:09:35]

Done.

+void CompositorFrameSinkHolder::OnNeedsBeginFrames(bool needs_begin_frames) {

[reveman, 2016/12/07 00:46:57]

nit: blankline before this

[Alex Z., 2016/12/07 20:09:35]

Done.

+  compositor_frame_sink_->SetNeedsBeginFrame(needs_begin_frames);
+}

[reveman, 2016/12/07 00:46:56]

nit: blankline after this

[Alex Z., 2016/12/07 20:09:35]

Done.

+}  // namespace exo