Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(155)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/exo/DEPS
Issue
2493223002
:
Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink (Closed)
Patch Set: Added CompositorFrameSinkHolder class and addressed comments"
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
components/exo/BUILD.gn
components/exo/DEPS
components/exo/compositor_frame_sink_holder.h
components/exo/compositor_frame_sink_holder.cc
components/exo/exo_compositor_frame_sink.h
components/exo/exo_compositor_frame_sink.cc
components/exo/surface.h
components/exo/surface.cc
components/exo/surface_unittest.cc
View unified diff
|
Download patch
« no previous file with comments
|
« components/exo/BUILD.gn
('k') |
components/exo/compositor_frame_sink_holder.h »
('j') |
components/exo/compositor_frame_sink_holder.h »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 "+ash",
2 "+ash",
3 "+cc",
3 "+cc",
4 "+chromeos/audio/chromeos_sounds.h",
4 "+chromeos/audio/chromeos_sounds.h",
5 "+device/gamepad",
5 "+device/gamepad",
6 "+gpu",
6 "+gpu",
7
"+mojo/public/cpp",
7 "+services/ui/public/cpp",
8 "+services/ui/public/cpp",
8 "+third_party/khronos",
9 "+third_party/khronos",
9 "+third_party/skia",
10 "+third_party/skia",
10 "+ui",
11 "+ui",
11 ]
12 ]
OLD
NEW
« no previous file with comments
|
« components/exo/BUILD.gn
('k') |
components/exo/compositor_frame_sink_holder.h »
('j') |
components/exo/compositor_frame_sink_holder.h »
('J')
Issue 2493223002: Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink (Closed)
Created 4 years, 1 month ago by Alex Z.
Modified 4 years ago
Reviewers: reveman, Fady Samuel, jbauman, sky, sadrul
Base URL:
Comments: 282
This is Rietveld
408576698