Issue 24932003: Use DEFINE_CSS_VALUE_TYPE_CASTS instead of using manual type cast function for CSSShaderValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24932003: Use DEFINE_CSS_VALUE_TYPE_CASTS instead of using manual type cast function for CSSShaderValue (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use DEFINE_CSS_VALUE_TYPE_CASTS instead of using manual type cast function for CSSShaderValue This cl changes isCSSShaderValue() to isShaderValue() in order to use DEFINE_CSS_VALUE_TYPE_CASTS template. Besides this cl checks if CSSValue is CSSShaderValue before doing a type cast so that it has same behavior with other type cast function. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158418

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -14 lines)			Patch
M	Source/core/css/CSSShaderValue.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	Source/core/css/CSSValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSValue.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/FilterOperationResolver.cpp	View	4 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/24932003/1

7 years, 2 months ago (2013-09-27 03:29:27 UTC) #3

Message was sent while issue was closed.

Change committed as 158418

Expand Messages | Collapse Messages