Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/unittests/interpreter/bytecode-register-optimizer-unittest.cc

Issue 2493183002: [ignition] Fix more -Wsign-compare warnings. (Closed)
Patch Set: Address comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/interpreter/bytecode-pipeline-unittest.cc ('k') | test/unittests/interpreter/constant-array-builder-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/bytecode-register-optimizer-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-register-optimizer-unittest.cc b/test/unittests/interpreter/bytecode-register-optimizer-unittest.cc
index fce3bb6756c317215d5cdc88af8285560eece46a..55003d7511ffa748acd87268acb6582063eb6d19 100644
--- a/test/unittests/interpreter/bytecode-register-optimizer-unittest.cc
+++ b/test/unittests/interpreter/bytecode-register-optimizer-unittest.cc
@@ -66,9 +66,9 @@ TEST_F(BytecodeRegisterOptimizerTest, TemporaryMaterializedForFlush) {
Initialize(1, 1);
Register temp = NewTemporary();
optimizer()->DoStar(temp, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
optimizer()->Flush();
- CHECK_EQ(write_count(), 1);
+ CHECK_EQ(write_count(), 1u);
CHECK_EQ(output()->at(0).bytecode(), Bytecode::kStar);
CHECK_EQ(output()->at(0).operand(0), static_cast<uint32_t>(temp.ToOperand()));
}
@@ -77,9 +77,9 @@ TEST_F(BytecodeRegisterOptimizerTest, TemporaryMaterializedForJump) {
Initialize(1, 1);
Register temp = NewTemporary();
optimizer()->DoStar(temp, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
optimizer()->PrepareForBytecode(Bytecode::kJump);
- CHECK_EQ(write_count(), 1);
+ CHECK_EQ(write_count(), 1u);
CHECK_EQ(output()->at(0).bytecode(), Bytecode::kStar);
CHECK_EQ(output()->at(0).operand(0), static_cast<uint32_t>(temp.ToOperand()));
}
@@ -90,12 +90,12 @@ TEST_F(BytecodeRegisterOptimizerTest, TemporaryNotEmitted) {
Initialize(3, 1);
Register parameter = Register::FromParameterIndex(1, 3);
optimizer()->DoLdar(parameter, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
Register temp = NewTemporary();
optimizer()->DoStar(temp, BytecodeSourceInfo());
BytecodeNode node1(Bytecode::kStar, NewTemporary().ToOperand());
ReleaseTemporaries(temp);
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
optimizer()->PrepareForBytecode(Bytecode::kReturn);
CHECK_EQ(output()->at(0).bytecode(), Bytecode::kLdar);
CHECK_EQ(output()->at(0).operand(0),
@@ -108,20 +108,20 @@ TEST_F(BytecodeRegisterOptimizerTest, ReleasedRegisterUsed) {
Register temp0 = NewTemporary();
Register temp1 = NewTemporary();
optimizer()->DoStar(temp1, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
optimizer()->PrepareForBytecode(Bytecode::kLdaSmi);
- CHECK_EQ(write_count(), 1);
+ CHECK_EQ(write_count(), 1u);
CHECK_EQ(output()->at(0).bytecode(), Bytecode::kStar);
CHECK_EQ(output()->at(0).operand(0),
static_cast<uint32_t>(temp1.ToOperand()));
optimizer()->DoMov(temp1, temp0, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 1);
+ CHECK_EQ(write_count(), 1u);
ReleaseTemporaries(temp1);
- CHECK_EQ(write_count(), 1);
+ CHECK_EQ(write_count(), 1u);
optimizer()->DoLdar(temp0, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 1);
+ CHECK_EQ(write_count(), 1u);
optimizer()->PrepareForBytecode(Bytecode::kReturn);
- CHECK_EQ(write_count(), 2);
+ CHECK_EQ(write_count(), 2u);
CHECK_EQ(output()->at(1).bytecode(), Bytecode::kLdar);
CHECK_EQ(output()->at(1).operand(0),
static_cast<uint32_t>(temp1.ToOperand()));
@@ -133,12 +133,12 @@ TEST_F(BytecodeRegisterOptimizerTest, ReleasedRegisterNotFlushed) {
Register temp0 = NewTemporary();
Register temp1 = NewTemporary();
optimizer()->DoStar(temp0, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
optimizer()->DoStar(temp1, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
ReleaseTemporaries(temp1);
optimizer()->Flush();
- CHECK_EQ(write_count(), 1);
+ CHECK_EQ(write_count(), 1u);
CHECK_EQ(output()->at(0).bytecode(), Bytecode::kStar);
CHECK_EQ(output()->at(0).operand(0),
static_cast<uint32_t>(temp0.ToOperand()));
@@ -148,10 +148,10 @@ TEST_F(BytecodeRegisterOptimizerTest, StoresToLocalsImmediate) {
Initialize(3, 1);
Register parameter = Register::FromParameterIndex(1, 3);
optimizer()->DoLdar(parameter, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
Register local = Register(0);
optimizer()->DoStar(local, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 1);
+ CHECK_EQ(write_count(), 1u);
CHECK_EQ(output()->at(0).bytecode(), Bytecode::kMov);
CHECK_EQ(output()->at(0).operand(0),
static_cast<uint32_t>(parameter.ToOperand()));
@@ -159,7 +159,7 @@ TEST_F(BytecodeRegisterOptimizerTest, StoresToLocalsImmediate) {
static_cast<uint32_t>(local.ToOperand()));
optimizer()->PrepareForBytecode(Bytecode::kReturn);
- CHECK_EQ(write_count(), 2);
+ CHECK_EQ(write_count(), 2u);
CHECK_EQ(output()->at(1).bytecode(), Bytecode::kLdar);
CHECK_EQ(output()->at(1).operand(0),
static_cast<uint32_t>(local.ToOperand()));
@@ -172,12 +172,12 @@ TEST_F(BytecodeRegisterOptimizerTest, SingleTemporaryNotMaterializedForInput) {
Register temp1 = NewTemporary();
optimizer()->DoMov(parameter, temp0, BytecodeSourceInfo());
optimizer()->DoMov(parameter, temp1, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
Register reg = optimizer()->GetInputRegister(temp0);
RegisterList reg_list =
optimizer()->GetInputRegisterList(RegisterList(temp0.index(), 1));
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
CHECK_EQ(parameter.index(), reg.index());
CHECK_EQ(parameter.index(), reg_list.first_register().index());
CHECK_EQ(1, reg_list.register_count());
@@ -191,14 +191,14 @@ TEST_F(BytecodeRegisterOptimizerTest, RangeOfTemporariesMaterializedForInput) {
optimizer()->PrepareForBytecode(Bytecode::kLdaSmi);
optimizer()->DoStar(temp0, BytecodeSourceInfo());
optimizer()->DoMov(parameter, temp1, BytecodeSourceInfo());
- CHECK_EQ(write_count(), 0);
+ CHECK_EQ(write_count(), 0u);
optimizer()->PrepareForBytecode(Bytecode::kCallJSRuntime);
RegisterList reg_list =
optimizer()->GetInputRegisterList(RegisterList(temp0.index(), 2));
CHECK_EQ(temp0.index(), reg_list.first_register().index());
CHECK_EQ(2, reg_list.register_count());
- CHECK_EQ(write_count(), 2);
+ CHECK_EQ(write_count(), 2u);
CHECK_EQ(output()->at(0).bytecode(), Bytecode::kStar);
CHECK_EQ(output()->at(0).operand(0),
static_cast<uint32_t>(temp0.ToOperand()));
« no previous file with comments | « test/unittests/interpreter/bytecode-pipeline-unittest.cc ('k') | test/unittests/interpreter/constant-array-builder-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698