test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc - Issue 2493183002: [ignition] Fix more -Wsign-compare warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

Issue 2493183002: [ignition] Fix more -Wsign-compare warnings. (Closed)

Patch Set: Address comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc b/test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

index c7ebc5d31496725b4e222d57918c2dba40663ced..d1c570d421cd45f1532a9751578677187054f64c 100644

--- a/test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

+++ b/test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

@@ -396,7 +396,7 @@ TEST_F(BytecodePeepholeOptimizerTest, MergeLdaZeroWithBinaryOp) {

CHECK_EQ(write_count(), 1);

CHECK_EQ(last_written().bytecode(), operator_replacement[1]);

CHECK_EQ(last_written().operand_count(), 3);

- CHECK_EQ(last_written().operand(0), 0);

+ CHECK_EQ(last_written().operand(0), 0u);

CHECK_EQ(last_written().operand(1), reg_operand);

CHECK_EQ(last_written().operand(2), idx_operand);

Reset();