[ignition] Fix more -Wsign-compare warnings.

test/unittests/interpreter/constant-array-builder-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/factory.h"
 #include "src/handles-inl.h"
 #include "src/interpreter/constant-array-builder.h"
 #include "src/isolate.h"
@@ skipping 25 matching lines @@
   }
   CHECK_EQ(builder.size(), k16BitCapacity);
   for (size_t i = 0; i < k16BitCapacity; i++) {
     CHECK_EQ(Handle<Smi>::cast(builder.At(i))->value(), static_cast<int>(i));
   }
 }
 
 TEST_F(ConstantArrayBuilderTest, ToFixedArray) {
   CanonicalHandleScope canonical(isolate());
   ConstantArrayBuilder builder(zone(), isolate()->factory()->the_hole_value());
-  static const size_t kNumberOfElements = 37;
-  for (size_t i = 0; i < kNumberOfElements; i++) {
+  static const int kNumberOfElements = 37;
+  for (int i = 0; i < kNumberOfElements; i++) {
     Handle<Object> object = isolate()->factory()->NewNumberFromSize(i);
     builder.Insert(object);
     CHECK(builder.At(i)->SameValue(*object));
   }
   Handle<FixedArray> constant_array = builder.ToFixedArray(isolate());
   CHECK_EQ(constant_array->length(), kNumberOfElements);
-  for (size_t i = 0; i < kNumberOfElements; i++) {
-    CHECK(constant_array->get(static_cast<int>(i))->SameValue(*builder.At(i)));
+  for (int i = 0; i < kNumberOfElements; i++) {
+    CHECK(constant_array->get(i)->SameValue(*builder.At(i)));
   }
 }
 
 TEST_F(ConstantArrayBuilderTest, ToLargeFixedArray) {
   CanonicalHandleScope canonical(isolate());
   ConstantArrayBuilder builder(zone(), isolate()->factory()->the_hole_value());
-  static const size_t kNumberOfElements = 37373;
-  for (size_t i = 0; i < kNumberOfElements; i++) {
+  static const int kNumberOfElements = 37373;
+  for (int i = 0; i < kNumberOfElements; i++) {
     Handle<Object> object = isolate()->factory()->NewNumberFromSize(i);
     builder.Insert(object);
     CHECK(builder.At(i)->SameValue(*object));
   }
   Handle<FixedArray> constant_array = builder.ToFixedArray(isolate());
   CHECK_EQ(constant_array->length(), kNumberOfElements);

[Michael Starzinger, 2016/11/11 11:45:43]

nit: As discussed offline: If the bogus conversion is this one, then I would
vote for keeping the variables size_t and do a cast here instead.

[ulan, 2016/11/11 11:47:25]

Done.

[rmcilroy, 2016/11/11 11:48:52]

Any reason to do this? It seems like Ulan's approach drops a bunch of unecessary
static_casts and doesn't have much negatives AFAIKT.

[Michael Starzinger, 2016/11/11 11:54:32]

My reasoning was that safe indexed vector accessors (like in [1]) should operate
on unsigned values. Similar container sizes are usually represented with
unsigned values (like in [2]). Maybe there are other factors at play in
{ConstantArrayBuilder} that I am not aware of, in which case I am sorry for the
distraction. Also, since this is test code, I don't care all too much.

[1] http://en.cppreference.com/w/cpp/container/vector/at
[2] http://en.cppreference.com/w/cpp/container/vector/size

-  for (size_t i = 0; i < kNumberOfElements; i++) {
-    CHECK(constant_array->get(static_cast<int>(i))->SameValue(*builder.At(i)));
+  for (int i = 0; i < kNumberOfElements; i++) {
+    CHECK(constant_array->get(i)->SameValue(*builder.At(i)));
   }
 }
 
 TEST_F(ConstantArrayBuilderTest, ToLargeFixedArrayWithReservations) {
   CanonicalHandleScope canonical(isolate());
   ConstantArrayBuilder builder(zone(), isolate()->factory()->the_hole_value());
-  static const size_t kNumberOfElements = 37373;
-  for (size_t i = 0; i < kNumberOfElements; i++) {
-    builder.CommitReservedEntry(builder.CreateReservedEntry(),
-                                Smi::FromInt(static_cast<int>(i)));
+  static const int kNumberOfElements = 37373;
+  for (int i = 0; i < kNumberOfElements; i++) {
+    builder.CommitReservedEntry(builder.CreateReservedEntry(), Smi::FromInt(i));
   }
   Handle<FixedArray> constant_array = builder.ToFixedArray(isolate());
   CHECK_EQ(constant_array->length(), kNumberOfElements);
-  for (size_t i = 0; i < kNumberOfElements; i++) {
-    CHECK(constant_array->get(static_cast<int>(i))->SameValue(*builder.At(i)));
+  for (int i = 0; i < kNumberOfElements; i++) {
+    CHECK(constant_array->get(i)->SameValue(*builder.At(i)));
   }
 }
 
 TEST_F(ConstantArrayBuilderTest, AllocateEntriesWithIdx8Reservations) {
   CanonicalHandleScope canonical(isolate());
   for (size_t reserved = 1; reserved < k8BitCapacity; reserved *= 3) {
     ConstantArrayBuilder builder(zone(),
                                  isolate()->factory()->the_hole_value());
     for (size_t i = 0; i < reserved; i++) {
       OperandSize operand_size = builder.CreateReservedEntry();
@@ skipping 100 matching lines @@
     }
   }
 }
 
 TEST_F(ConstantArrayBuilderTest, GapFilledWhenLowReservationCommitted) {
   CanonicalHandleScope canonical(isolate());
   ConstantArrayBuilder builder(zone(), isolate()->factory()->the_hole_value());
   for (size_t i = 0; i < k8BitCapacity; i++) {
     OperandSize operand_size = builder.CreateReservedEntry();
     CHECK(OperandSize::kByte == operand_size);
-    CHECK_EQ(builder.size(), 0);
+    CHECK_EQ(builder.size(), 0u);
   }
   for (size_t i = 0; i < k8BitCapacity; i++) {
     builder.CommitReservedEntry(builder.CreateReservedEntry(),
                                 Smi::FromInt(static_cast<int>(i)));
     CHECK_EQ(builder.size(), i + k8BitCapacity + 1);
   }
   for (size_t i = 0; i < k8BitCapacity; i++) {
     builder.CommitReservedEntry(OperandSize::kByte,
                                 Smi::FromInt(static_cast<int>(i)));
     CHECK_EQ(builder.size(), 2 * k8BitCapacity);
   }
   Handle<FixedArray> constant_array = builder.ToFixedArray(isolate());
-  CHECK_EQ(constant_array->length(), 2 * k8BitCapacity);
+  CHECK_EQ(constant_array->length(), static_cast<int>(2 * k8BitCapacity));
   for (size_t i = 0; i < k8BitCapacity; i++) {
     Object* original = constant_array->get(static_cast<int>(k8BitCapacity + i));
     Object* duplicate = constant_array->get(static_cast<int>(i));
     CHECK(original->SameValue(duplicate));
     Handle<Object> reference = isolate()->factory()->NewNumberFromSize(i);
     CHECK(original->SameValue(*reference));
   }
 }
 
 TEST_F(ConstantArrayBuilderTest, GapNotFilledWhenLowReservationDiscarded) {
   CanonicalHandleScope canonical(isolate());
   ConstantArrayBuilder builder(zone(), isolate()->factory()->the_hole_value());
   for (size_t i = 0; i < k8BitCapacity; i++) {
     OperandSize operand_size = builder.CreateReservedEntry();
     CHECK(OperandSize::kByte == operand_size);
-    CHECK_EQ(builder.size(), 0);
+    CHECK_EQ(builder.size(), 0u);
   }
   for (size_t i = 0; i < k8BitCapacity; i++) {
     Handle<Object> object = isolate()->factory()->NewNumberFromSize(i);
     builder.Insert(object);
     CHECK_EQ(builder.size(), i + k8BitCapacity + 1);
   }
   for (size_t i = 0; i < k8BitCapacity; i++) {
     builder.DiscardReservedEntry(OperandSize::kByte);
     builder.Insert(builder.At(i + k8BitCapacity));
     CHECK_EQ(builder.size(), 2 * k8BitCapacity);
@@ skipping 11 matching lines @@
   CanonicalHandleScope canonical(isolate());
   static int kNumberOfHoles = 128;
   ConstantArrayBuilder builder(zone(), isolate()->factory()->the_hole_value());
   for (int i = 0; i < kNumberOfHoles; ++i) {
     CHECK_EQ(builder.CreateReservedEntry(), OperandSize::kByte);
   }
   for (int i = 0; i < 128; ++i) {
     CHECK_EQ(builder.Insert(isolate()->factory()->NewNumber(i)),
              static_cast<size_t>(i));
   }
-  CHECK_EQ(builder.Insert(isolate()->factory()->NewNumber(256)), 256);
+  CHECK_EQ(builder.Insert(isolate()->factory()->NewNumber(256)), 256u);
 
   Handle<FixedArray> constant_array = builder.ToFixedArray(isolate());
   CHECK_EQ(constant_array->length(), 257);
   for (int i = 128; i < 256; i++) {
     CHECK(constant_array->get(i)->SameValue(
         *isolate()->factory()->the_hole_value()));
   }
   CHECK(!constant_array->get(127)->SameValue(
       *isolate()->factory()->the_hole_value()));
   CHECK(!constant_array->get(256)->SameValue(
       *isolate()->factory()->the_hole_value()));
 }
 
 TEST_F(ConstantArrayBuilderTest, ReservationsAtAllScales) {
   CanonicalHandleScope canonical(isolate());
   ConstantArrayBuilder builder(zone(), isolate()->factory()->the_hole_value());
   for (int i = 0; i < 256; i++) {
     CHECK_EQ(builder.CreateReservedEntry(), OperandSize::kByte);
   }
   for (int i = 256; i < 65536; ++i) {
     CHECK_EQ(builder.CreateReservedEntry(), OperandSize::kShort);
   }
   for (int i = 65536; i < 131072; ++i) {
     CHECK_EQ(builder.CreateReservedEntry(), OperandSize::kQuad);
   }
-  CHECK_EQ(builder.CommitReservedEntry(OperandSize::kByte, Smi::FromInt(1)), 0);
+  CHECK_EQ(builder.CommitReservedEntry(OperandSize::kByte, Smi::FromInt(1)),
+           0u);
   CHECK_EQ(builder.CommitReservedEntry(OperandSize::kShort, Smi::FromInt(2)),
-           256);
+           256u);
   CHECK_EQ(builder.CommitReservedEntry(OperandSize::kQuad, Smi::FromInt(3)),
-           65536);
+           65536u);
   Handle<FixedArray> constant_array = builder.ToFixedArray(isolate());
   CHECK_EQ(constant_array->length(), 65537);
   int count = 1;
   for (int i = 0; i < constant_array->length(); ++i) {
     Handle<Object> expected;
     if (i == 0 || i == 256 || i == 65536) {
       expected = isolate()->factory()->NewNumber(count++);
     } else {
       expected = isolate()->factory()->the_hole_value();
     }
@@ skipping 32 matching lines @@
 
   // Check values after reserved entries are inserted.
   for (size_t i = 0; i < k16BitCapacity; i++) {
     CHECK_EQ(Handle<Smi>::cast(builder.At(i))->value(), static_cast<int>(i));
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8