LayoutTests/svg/custom/fragment-navigation-01.html - Issue 249313005: Allow fragment navigation from <svg:a>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/fragment-navigation-01.html

Issue 249313005: Allow fragment navigation from <svg:a> (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <div>

	3 <p>Clicking the green rectangle should attempt a navigation to the fragment id entifier.</p>

	4 <svg width="300" height="200" onload="runTest()">

	5 <a xlink:href="#test">
	pdr. 2014/04/24 19:40:05 I think this test would pass even without the patc I think this test would pass even without the patch because there's no element width id test so targetElement would be null. Could you add a second test that the page correctly navigates to the target fragment? In my tests we just go to the bottom of the page. fs 2014/04/25 08:00:09 Added an additional test similar to the TC in the Show quoted text On 2014/04/24 19:40:05, pdr wrote: > I think this test would pass even without the patch because there's no element > width id test so targetElement would be null. Could you add a second test that > the page correctly navigates to the target fragment? In my tests we just go to > the bottom of the page. Added an additional test similar to the TC in the bug.
	6 <rect width="100" height="100" fill="green"/>

	7 </a>

	8 </svg>

	9 </div>

	10 <script>

	11 if (window.testRunner) {

	12 testRunner.waitUntilDone();

	13 testRunner.dumpAsText();

	14 }

	15

	16 function runTest() {

	17 var evt = document.createEvent("MouseEvents");

	18 evt.initMouseEvent("click", true, true, window,

	19 0, 0, 0, 0, 0, false, false, false, false, 0, null);

	20 document.querySelector('a').dispatchEvent(evt);

	21 window.setTimeout(function checkNavigation() {

	22 var result = location.hash === '#test' ? 'PASS' : 'FAIL';

	23 document.documentElement.appendChild(document.createTextNode(result));

	24 if (window.testRunner)

	25 testRunner.notifyDone();

	26 }, 0);

	27 }

	28 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/custom/fragment-navigation-01-expected.txt » ('j') | no next file with comments »