Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 249313002: Remove static CallCompletedCallback handlers (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove static CallCompletedCallback handlers BUG=none R=svenpanne@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=20985

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -92 lines) Patch
M include/v8.h View 1 chunk +0 lines, -18 lines 0 comments Download
M src/api.cc View 4 chunks +5 lines, -16 lines 0 comments Download
M src/isolate.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +33 lines, -0 lines 2 comments Download
M src/v8.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/v8.cc View 3 chunks +0 lines, -46 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-23 13:29:42 UTC) #1
Sven Panne
LGTM (although it contains weird code :-) https://codereview.chromium.org/249313002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/249313002/diff/1/src/isolate.cc#newcode2281 src/isolate.cc:2281: if (!handle_scope_implementer()->CallDepthIsZero()) ...
6 years, 8 months ago (2014-04-24 07:08:20 UTC) #2
Sven Panne
LGTM (although it contains weird code :-)
6 years, 8 months ago (2014-04-24 07:08:21 UTC) #3
Yang
https://codereview.chromium.org/249313002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/249313002/diff/1/src/isolate.cc#newcode2281 src/isolate.cc:2281: if (!handle_scope_implementer()->CallDepthIsZero()) return; On 2014/04/24 07:08:21, Sven Panne wrote: ...
6 years, 8 months ago (2014-04-24 07:16:38 UTC) #4
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-25 13:49:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r20985 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698