Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2493093003: Reland of WebRTC: Add cleanup_symlinks step on all bots. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of WebRTC: Add cleanup_symlinks step on all bots. (patchset #1 id:1 of https://codereview.chromium.org/2492823002/ ) Reason for revert: Relanding since the failure was caused by a Google storage transient outage rather than because of this change: subprocess.CalledProcessError: Command '['wget', '--quiet', '-t', '3', '-O', '/b/build/slave/linux64/build/src/chromium/src/build/linux/debian_wheezy_i386-sysroot/debian_wheezy_i386_sysroot.tgz', 'https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/7d200a1ddfeb50dbf9f7e2c1c4ff1080679edf02/debian_wheezy_i386_sysroot.tgz']' returned non-zero exit status 8 Error: Command '/usr/bin/python src/build/linux/sysroot_scripts/install-sysroot.py --running-as-hook' returned non-zero exit status 1 in https://build.chromium.org/p/client.webrtc/builders/Linux%20%28more%20configs%29/builds/165/steps/gclient%20runhooks/logs/stdio Original issue's description: > Revert of WebRTC: Add cleanup_symlinks step on all bots. (patchset #1 id:1 of https://codereview.chromium.org/2484423003/ ) > > Reason for revert: > This might be breaking Linux (more configs) > > Original issue's description: > > WebRTC: Add cleanup_symlinks step on all bots. > > > > Now that this is finally working as intended in the client.webrtc.fyi > > waterfall we should be able to turn it on for all bots. > > > > BUG=663278 > > > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/73ebb69974d1d0f2f979da0e6a129100a83d2a78 > > TBR=kjellander@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=663278 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/fa77e5b771b53a6b007c88c46cb100c56a7395e8 TBR=ehmaldonado@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=663278 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f1d85d6da3c74730f856aa109551ff909b75529e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1031 lines, -7 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +5 lines, -7 lines 0 comments Download
M scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/libfuzzer.expected/full_tryserver_webrtc_linux_libfuzzer_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Android32__more_configs_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_mips__dbg_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_x86.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_builder_x86__dbg_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_clang__dbg_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gyp.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_gyp__dbg_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_builder_x64__dbg_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_arm.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__gyp_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gyp_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__large_tests_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug__gyp_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__gyp_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__large_tests_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced_invalid.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__gyp_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__gyp_.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_clang_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_arm64_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_mips_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x64_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_compile_x86_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gyp_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gyp_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gyp_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gyp_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_swarming.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gyp_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gyp_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_swarming.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_swarming.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gyp_dbg.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gyp_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json View 1 chunk +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
Created Reland of WebRTC: Add cleanup_symlinks step on all bots.
4 years, 1 month ago (2016-11-11 06:26:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493093003/1
4 years, 1 month ago (2016-11-11 06:26:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/f1d85d6da3c74730f856aa109551ff909b75529e
4 years, 1 month ago (2016-11-11 06:26:46 UTC) #5
ehmaldonado_chromium
On 2016/11/11 06:26:46, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 1 month ago (2016-11-11 06:28:53 UTC) #6
ehmaldonado_chromium
4 years, 1 month ago (2016-11-11 06:28:56 UTC) #7
Message was sent while issue was closed. 
On 2016/11/11 06:26:46, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/tools/build/+/f1d85d6da3c74730f856...
LGTM
Let's see :)

Powered by Google App Engine
This is Rietveld 408576698