Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: content/browser/devtools/protocol_string.h

Issue 2493063005: [DevTools] Use inspector_protocol generator in content/browser/devtools. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol_string.h
diff --git a/content/browser/devtools/protocol_string.h b/content/browser/devtools/protocol_string.h
new file mode 100644
index 0000000000000000000000000000000000000000..f31ec43cc5a059dd7fd8308c846afef35df8f15d
--- /dev/null
+++ b/content/browser/devtools/protocol_string.h
@@ -0,0 +1,60 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_STRING_H
+#define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_STRING_H
+
+#include <memory>
+#include <string>
+
+#include "base/logging.h"
+#include "base/macros.h"
+#include "base/strings/string_number_conversions.h"
+#include "content/common/content_export.h"
+
+namespace content {
+
+class CONTENT_EXPORT ProtocolStringBuilder {
caseq 2016/11/12 02:17:04 perhaps get it into protocol or otherwise avoid ex
dgozman 2016/11/14 18:40:28 Done.
+ public:
+ ProtocolStringBuilder();
+ ~ProtocolStringBuilder();
+ void append(const std::string&);
+ void append(char);
+ void append(const char*, size_t);
+ std::string toString();
+ void reserveCapacity(size_t);
+
+ private:
+ std::vector<char> buffer_;
caseq 2016/11/12 02:17:04 let's just += a string.
dgozman 2016/11/14 18:40:28 Done.
+};
+
+namespace protocol {
+
+class Value;
+
+using String = std::string;
+using StringBuilder = ProtocolStringBuilder;
+
+class CONTENT_EXPORT StringUtil {
+ public:
+ static String substring(const String& s, unsigned pos, unsigned len) {
+ return s.substr(pos, len);
+ }
+ static String fromInteger(int number) {
+ return base::IntToString(number);
+ }
+ static String fromDouble(double number) {
+ return base::DoubleToString(number);
+ }
+ static const size_t kNotFound = static_cast<size_t>(-1);
+ static void builderReserve(StringBuilder& builder, unsigned capacity) {
+ builder.reserveCapacity(capacity);
+ }
+ static std::unique_ptr<protocol::Value> parseJSON(const String&);
+};
+
+} // namespace protocol
+} // namespace content
+
+#endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_STRING_H

Powered by Google App Engine
This is Rietveld 408576698