Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2493063002:
Enable traffic shaping in loading.mobile benchmark (Closed)
|
Created:
4 years, 1 month ago by Kunihiko Sakamoto Modified:
4 years ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org, kouhei (in TOK) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable traffic shaping in loading.mobile benchmark
After this patch, loading.mobile benchmark will run with two traffic
configurations:
- No traffic shaping (as before)
- "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT)
BUG=664420
Committed: https://crrev.com/9febcf5133be621b82954c0fea52123fa4f8b7a8
Cr-Commit-Position: refs/heads/master@{#435230}
Patch Set 1 #
Messages
Total messages: 36 (26 generated)
Description was changed from ========== Traffic setting ========== to ========== Traffic setting CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Traffic setting CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
Patchset #1 (id:20001) has been deleted
nednguyen@google.com changed reviewers: + nednguyen@google.com
lgtm
On 2016/11/30 01:03:03, nednguyen wrote: > lgtm Just remove "master.tryserver.chromium.perf:android_s5_perf_cq" from CQ_INLUCDE_TRYBOTS
Description was changed from ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Removing "master.tryserver.chromium.perf:android_s5_perf_cq" and CQ-ing.
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
On 2016/11/30 12:00:33, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build > URL) Removed all CQ_INCLUDE_TRYBOTS since they already pass.
Description was changed from ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480507764870310,
"parent_rev": "312ca249935bf774a7152bde3074d5eebf97c049", "commit_rev":
"404bb6c2a04077904a57c94e3481825de8ccd6a6"}
Message was sent while issue was closed.
Description was changed from ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 ========== to ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 ========== to ========== Enable traffic shaping in loading.mobile benchmark After this patch, loading.mobile benchmark will run with two traffic configurations: - No traffic shaping (as before) - "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT) BUG=664420 Committed: https://crrev.com/9febcf5133be621b82954c0fea52123fa4f8b7a8 Cr-Commit-Position: refs/heads/master@{#435230} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9febcf5133be621b82954c0fea52123fa4f8b7a8 Cr-Commit-Position: refs/heads/master@{#435230}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in https://codereview.chromium.org/2556873002/ by dtu@chromium.org. The reason for reverting is: loading.mobile started failing after this CL. See http://crbug.com/671640#c10. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
