Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: extensions/shell/common/shell_extensions_client.h

Issue 2493053002: [extensions] Stop parsing webstore urls so much (Closed)
Patch Set: rdevlin review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extensions_client.h ('k') | extensions/shell/common/shell_extensions_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/common/shell_extensions_client.h
diff --git a/extensions/shell/common/shell_extensions_client.h b/extensions/shell/common/shell_extensions_client.h
index 1398d8706385b08ba47e8750d951f0b9aff52c60..b9bb22c677013168e59970f815979391cd5e9753 100644
--- a/extensions/shell/common/shell_extensions_client.h
+++ b/extensions/shell/common/shell_extensions_client.h
@@ -9,6 +9,7 @@
#include "base/macros.h"
#include "extensions/common/extensions_client.h"
#include "extensions/common/permissions/extensions_api_permissions.h"
+#include "url/gurl.h"
namespace extensions {
@@ -41,7 +42,7 @@ class ShellExtensionsClient : public ExtensionsClient {
bool ShouldSuppressFatalErrors() const override;
void RecordDidSuppressFatalError() override;
std::string GetWebstoreBaseURL() const override;
- std::string GetWebstoreUpdateURL() const override;
+ const GURL& GetWebstoreUpdateURL() const override;
bool IsBlacklistUpdateURL(const GURL& url) const override;
private:
@@ -49,6 +50,8 @@ class ShellExtensionsClient : public ExtensionsClient {
ScriptingWhitelist scripting_whitelist_;
+ const GURL webstore_update_url_;
+
DISALLOW_COPY_AND_ASSIGN(ShellExtensionsClient);
};
« no previous file with comments | « extensions/common/extensions_client.h ('k') | extensions/shell/common/shell_extensions_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698