Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 249303002: Revert of Use platform's device scale factor for cursor (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
Reviewers:
tdanderson, oshima, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, mazda+watch_chromium.org, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Use platform's device scale factor for cursor (https://codereview.chromium.org/226293005/) Reason for revert: There are no resize cursors in DevTools on Linux Aura anymore. Original issue's description: > Use platform's device scale factor for cursor instead of gfx::Display because gfx::Display's DSF may differ from > platform's one when UI scaling is used. > > BUG=361672 > TEST=covered by unit test > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265592 TBR=tdanderson@chromium.org,sky@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=361672 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -131 lines) Patch
M ash/display/display_controller_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/display/display_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/display/screen_ash.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/test/cursor_manager_test_api.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/test/cursor_manager_test_api.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M ash/wm/ash_native_cursor_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager_interactive_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 4 chunks +22 lines, -49 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/image_cursors.h View 3 chunks +11 lines, -4 lines 0 comments Download
M ash/wm/image_cursors.cc View 3 chunks +26 lines, -28 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cursor/cursor_loader.h View 2 chunks +8 lines, -6 lines 0 comments Download
M ui/base/cursor/cursor_loader_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cursor/cursor_loader_x11.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of Use platform's device scale factor for cursor
6 years, 8 months ago (2014-04-23 13:21:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/249303002/1
6 years, 8 months ago (2014-04-23 13:21:23 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 13:24:15 UTC) #3
Message was sent while issue was closed. 
Change committed as 265625

Powered by Google App Engine
This is Rietveld 408576698