Issue 2493002: - Remove [static] from methods in Zone and associated helpers.

Issue 2493002: - Remove [static] from methods in Zone and associated helpers. (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

- Remove [static] from methods in Zone and associated helpers. - Experiment with a way to handle isolate-global statics. Committed: http://code.google.com/p/v8/source/detail?r=4789

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 4

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -50 lines)			Patch
M	src/data-flow.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/isolate.h	View	1 2 3	5 chunks	+29 lines, -6 lines	2 comments	Download
M	src/isolate.cc	View	3	1 chunk	+4 lines, -0 lines	1 comment	Download
M	src/parser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/scopes.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/zone.h	View	1 2	6 chunks	+19 lines, -27 lines	0 comments	Download
M	src/zone.cc	View	3	3 chunks	+15 lines, -8 lines	0 comments	Download
M	src/zone-inl.h	View	1 2	4 chunks	+26 lines, -2 lines	1 comment	Download
M	test/cctest/test-ast.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-dataflow.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-liveedit.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View		8 chunks	+8 lines, -0 lines	0 comments	Download
M	test/cctest/test-strings.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 6 months ago (2010-06-02 15:30:40 UTC) #4

LGTM

http://codereview.chromium.org/2493002/diff/9003/32002
File src/isolate.cc (right):

http://codereview.chromium.org/2493002/diff/9003/32002#newcode71
src/isolate.cc:71: name##_ = initialvalue;
Use "(initial_value)" just in case.

http://codereview.chromium.org/2493002/diff/9003/32003
File src/isolate.h (right):

http://codereview.chromium.org/2493002/diff/9003/32003#newcode59
src/isolate.h:59: ~Isolate();
BTW, according to the style guide this should be the first thing in this class.

http://codereview.chromium.org/2493002/diff/9003/32003#newcode105
src/isolate.h:105: #define STATIC_CLASS class
Do we really need this?

http://codereview.chromium.org/2493002/diff/9003/32006
File src/zone-inl.h (right):

http://codereview.chromium.org/2493002/diff/9003/32006#newcode92
src/zone-inl.h:92: // TODO(isolates): maybe replace uses of this with placement
new so that
"placement new" -> "new operator that takes a zone to allocate in". A comment
should end with full stop.

Expand Messages | Collapse Messages