Issue 2493001: - Continue removing [static] qualifier from StubCache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2493001: - Continue removing [static] qualifier from StubCache. (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

- Continue removing [static] qualifier from StubCache. Committed: http://code.google.com/p/v8/source/detail?r=4781

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -33 lines)			Patch
M	src/arm/ic-arm.cc	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	src/codegen.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/handles.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/ic-ia32.cc	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	src/ic.cc	View		5 chunks	+10 lines, -5 lines	0 comments	Download
M	src/isolate.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/stub-cache.h	View	1	5 chunks	+14 lines, -14 lines	0 comments	Download
M	src/x64/ic-x64.cc	View		4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 6 months ago (2010-06-02 08:58:47 UTC) #2

LGTM

http://codereview.chromium.org/2493001/diff/1/7
File src/stub-cache.h (right):

http://codereview.chromium.org/2493001/diff/1/7#newcode268
src/stub-cache.h:268: Entry* entry(Entry* table, int offset) {
I think this should stay a static function. I doesn't depend on any StubCache
instance.

Expand Messages | Collapse Messages