Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 2492963003: Completing refactor of startup_browser_creator_impl. This includes: (Closed)

Created:
4 years, 1 month ago by Moe
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Completing refactor of startup_browser_creator_impl. This includes: - Reintroducing session restore logic. - Preventing Win 10 from branching on this codepath, as Win10 has been descoped from this launch. - Correcting several small but critical bugs surfaced by session restore path: - Unexpected content in Guest Mode. - NTP showing unexpectedly on restored sessions. - Pinned tabs appearing duplicated on restored sessions. BUG=660210 Review-Url: https://codereview.chromium.org/2457653003 Cr-Commit-Position: refs/heads/master@{#429303} (cherry picked from commit 43f9c50bcb8b440c0f462b69f13b4bf9994e639b)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -43 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator_impl.h View 3 chunks +41 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 8 chunks +158 lines, -19 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc View 10 chunks +27 lines, -12 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.h View 3 chunks +23 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.cc View 3 chunks +32 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider_unittest.cc View 2 chunks +52 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Moe
4 years, 1 month ago (2016-11-11 23:23:20 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
24dcead8ebfce8fa89bec45c2e737725e9b340b3.

Powered by Google App Engine
This is Rietveld 408576698