Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2492963002: bot_update: Use 'gclient' from same repository. (Closed)

Created:
4 years, 1 month ago by dnj
Modified:
4 years, 1 month ago
Reviewers:
nodir, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

bot_update: Use 'gclient' from same repository. Currently, 'bot_update' uses the 'gclient' that is on the system path. Now, it will use the 'gclient.py' that is in the same 'depot_tools' checkout as the 'bot_update' recipe module. Also don't ignore "git_cache" move errors. BUG=664254, 663990, 663440 TEST=None Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b445ef568c6d58762339b7e69f99d7095327a5d2

Patch Set 1 #

Patch Set 2 : Also don't ignore move errors in git cache. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M git_cache.py View 1 1 chunk +3 lines, -10 lines 0 comments Download
M recipe_modules/bot_update/resources/bot_update.py View 1 4 chunks +20 lines, -8 lines 0 comments Download
M tests/bot_update_coverage_test.py View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dnj
4 years, 1 month ago (2016-11-10 23:37:19 UTC) #1
nodir
lgtm
4 years, 1 month ago (2016-11-10 23:39:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492963002/1
4 years, 1 month ago (2016-11-10 23:43:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492963002/20001
4 years, 1 month ago (2016-11-10 23:48:04 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 23:51:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/b445ef568c6d58...

Powered by Google App Engine
This is Rietveld 408576698