Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: media/renderers/audio_renderer_impl_unittest.cc

Issue 2492953003: media: Delete renderer/demuxer splicing code. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/renderers/audio_renderer_impl.h" 5 #include "media/renderers/audio_renderer_impl.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/callback_helpers.h" 11 #include "base/callback_helpers.h"
12 #include "base/format_macros.h" 12 #include "base/format_macros.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/run_loop.h" 14 #include "base/run_loop.h"
15 #include "base/single_thread_task_runner.h" 15 #include "base/single_thread_task_runner.h"
16 #include "base/strings/stringprintf.h" 16 #include "base/strings/stringprintf.h"
17 #include "base/test/simple_test_tick_clock.h" 17 #include "base/test/simple_test_tick_clock.h"
18 #include "media/base/audio_buffer_converter.h" 18 #include "media/base/audio_buffer_converter.h"
19 #include "media/base/audio_splicer.h"
20 #include "media/base/fake_audio_renderer_sink.h" 19 #include "media/base/fake_audio_renderer_sink.h"
21 #include "media/base/gmock_callback_support.h" 20 #include "media/base/gmock_callback_support.h"
22 #include "media/base/media_util.h" 21 #include "media/base/media_util.h"
23 #include "media/base/mock_filters.h" 22 #include "media/base/mock_filters.h"
24 #include "media/base/test_helpers.h" 23 #include "media/base/test_helpers.h"
25 #include "testing/gtest/include/gtest/gtest.h" 24 #include "testing/gtest/include/gtest/gtest.h"
26 25
27 using ::base::TimeDelta; 26 using ::base::TimeDelta;
28 using ::testing::_; 27 using ::testing::_;
29 using ::testing::Return; 28 using ::testing::Return;
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 362
364 void force_config_change() { 363 void force_config_change() {
365 renderer_->OnConfigChange(); 364 renderer_->OnConfigChange();
366 } 365 }
367 366
368 InputFrames converter_input_frames_left() const { 367 InputFrames converter_input_frames_left() const {
369 return InputFrames( 368 return InputFrames(
370 renderer_->buffer_converter_->input_frames_left_for_testing()); 369 renderer_->buffer_converter_->input_frames_left_for_testing());
371 } 370 }
372 371
373 bool splicer_has_next_buffer() const {
374 return renderer_->splicer_->HasNextBuffer();
375 }
376
377 base::TimeDelta CurrentMediaTime() { 372 base::TimeDelta CurrentMediaTime() {
378 return renderer_->CurrentMediaTime(); 373 return renderer_->CurrentMediaTime();
379 } 374 }
380 375
381 bool ended() const { return ended_; } 376 bool ended() const { return ended_; }
382 377
383 // Fixture members. 378 // Fixture members.
384 AudioParameters hardware_params_; 379 AudioParameters hardware_params_;
385 base::MessageLoop message_loop_; 380 base::MessageLoop message_loop_;
386 std::unique_ptr<AudioRendererImpl> renderer_; 381 std::unique_ptr<AudioRendererImpl> renderer_;
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 } 661 }
667 662
668 TEST_F(AudioRendererImplTest, InitializeThenDestroy) { 663 TEST_F(AudioRendererImplTest, InitializeThenDestroy) {
669 InitializeAndDestroy(); 664 InitializeAndDestroy();
670 } 665 }
671 666
672 TEST_F(AudioRendererImplTest, InitializeThenDestroyDuringDecoderInit) { 667 TEST_F(AudioRendererImplTest, InitializeThenDestroyDuringDecoderInit) {
673 InitializeAndDestroyDuringDecoderInit(); 668 InitializeAndDestroyDuringDecoderInit();
674 } 669 }
675 670
671 //
672 // TODO- CONFIG change no longer drains converter. Anything to test here?
673 //
676 TEST_F(AudioRendererImplTest, ConfigChangeDrainsConverter) { 674 TEST_F(AudioRendererImplTest, ConfigChangeDrainsConverter) {
677 Initialize(); 675 Initialize();
678 Preroll(); 676 Preroll();
679 StartTicking(); 677 StartTicking();
680 678
681 // Drain internal buffer, we should have a pending read. 679 // Drain internal buffer, we should have a pending read.
682 EXPECT_TRUE(ConsumeBufferedData(frames_buffered())); 680 EXPECT_TRUE(ConsumeBufferedData(frames_buffered()));
683 WaitForPendingRead(); 681 WaitForPendingRead();
684 682
685 // Deliver a little bit of data. Use an odd data size to ensure there is data 683 // Deliver a little bit of data. Use an odd data size to ensure there is data
686 // left in the AudioBufferConverter. Ensure no buffers are in the splicer. 684 // left in the AudioBufferConverter. Ensure no buffers are in the splicer.
687 SatisfyPendingRead(InputFrames(2053)); 685 SatisfyPendingRead(InputFrames(2053));
688 EXPECT_FALSE(splicer_has_next_buffer()); 686 // EXPECT_FALSE(splicer_has_next_buffer());
689 EXPECT_GT(converter_input_frames_left().value, 0); 687 EXPECT_GT(converter_input_frames_left().value, 0);
690 688
691 // Force a config change and then ensure all buffered data has been put into 689 // Force a config change and then ensure all buffered data has been put into
692 // the splicer. 690 // the splicer.
693 force_config_change(); 691 force_config_change();
694 EXPECT_TRUE(splicer_has_next_buffer()); 692 // EXPECT_TRUE(splicer_has_next_buffer());
695 EXPECT_EQ(0, converter_input_frames_left().value); 693 EXPECT_EQ(0, converter_input_frames_left().value);
696 } 694 }
697 695
698 TEST_F(AudioRendererImplTest, CurrentMediaTimeBehavior) { 696 TEST_F(AudioRendererImplTest, CurrentMediaTimeBehavior) {
699 Initialize(); 697 Initialize();
700 Preroll(); 698 Preroll();
701 StartTicking(); 699 StartTicking();
702 700
703 AudioTimestampHelper timestamp_helper(kOutputSamplesPerSecond); 701 AudioTimestampHelper timestamp_helper(kOutputSamplesPerSecond);
704 timestamp_helper.SetBaseTimestamp(base::TimeDelta()); 702 timestamp_helper.SetBaseTimestamp(base::TimeDelta());
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
1020 // Advance far enough that we shouldn't be clamped to current time (tested 1018 // Advance far enough that we shouldn't be clamped to current time (tested
1021 // already above). 1019 // already above).
1022 tick_clock_->Advance(kOneSecond); 1020 tick_clock_->Advance(kOneSecond);
1023 EXPECT_EQ( 1021 EXPECT_EQ(
1024 current_time + timestamp_helper.GetFrameDuration(frames_to_consume.value), 1022 current_time + timestamp_helper.GetFrameDuration(frames_to_consume.value),
1025 CurrentMediaWallClockTime(&is_time_moving)); 1023 CurrentMediaWallClockTime(&is_time_moving));
1026 EXPECT_TRUE(is_time_moving); 1024 EXPECT_TRUE(is_time_moving);
1027 } 1025 }
1028 1026
1029 } // namespace media 1027 } // namespace media
OLDNEW
« media/base/stream_parser_buffer.cc ('K') | « media/renderers/audio_renderer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698