Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2492953003: media: Delete renderer/demuxer splicing code. (Closed)

Created:
4 years, 1 month ago by chcunningham
Modified:
4 years, 1 month ago
Reviewers:
DaleCurtis
CC:
apacible+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Delete renderer/demuxer splicing code. As of https://codereview.chromium.org/2343543002/, crossfaded splicing is no longer a thing. Now we simply trim overlapped buffers. This CL deletes the remaining splicing code. BUG=588351, 577438 Committed: https://crrev.com/8ae8c69e525729f91c22544659705689765ef58a Cr-Commit-Position: refs/heads/master@{#431488}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove test #

Patch Set 3 : cleanup #

Total comments: 1

Patch Set 4 : Fix/format EsAdapterVideoTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1734 lines) Patch
M media/base/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D media/base/audio_splicer.h View 1 chunk +0 lines, -128 lines 0 comments Download
D media/base/audio_splicer.cc View 1 chunk +0 lines, -560 lines 0 comments Download
D media/base/audio_splicer_unittest.cc View 1 chunk +0 lines, -770 lines 0 comments Download
M media/base/fake_demuxer_stream.h View 2 chunks +0 lines, -6 lines 0 comments Download
M media/base/fake_demuxer_stream.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/base/media_log.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/pipeline_status.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/stream_parser_buffer.h View 3 chunks +2 lines, -22 lines 0 comments Download
M media/base/stream_parser_buffer.cc View 4 chunks +1 line, -108 lines 0 comments Download
M media/blink/webmediaplayer_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/decoder_stream.h View 2 chunks +0 lines, -15 lines 0 comments Download
M media/filters/decoder_stream.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M media/filters/source_buffer_range.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/source_buffer_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M media/formats/mp2t/es_adapter_video_unittest.cc View 1 2 3 9 chunks +15 lines, -14 lines 0 comments Download
M media/renderers/audio_renderer_impl.h View 1 2 5 chunks +4 lines, -8 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 1 2 8 chunks +7 lines, -33 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 1 3 chunks +0 lines, -27 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
chcunningham
https://codereview.chromium.org/2492953003/diff/1/media/base/stream_parser_buffer.cc File media/base/stream_parser_buffer.cc (right): https://codereview.chromium.org/2492953003/diff/1/media/base/stream_parser_buffer.cc#newcode120 media/base/stream_parser_buffer.cc:120: preroll_buffer_->SetConfigId(GetConfigId()); This seemed to be missing. Probably not critical.
4 years, 1 month ago (2016-11-11 00:50:50 UTC) #3
DaleCurtis
lgtm \o/ https://codereview.chromium.org/2492953003/diff/40001/media/base/pipeline_status.h File media/base/pipeline_status.h (right): https://codereview.chromium.org/2492953003/diff/40001/media/base/pipeline_status.h#newcode47 media/base/pipeline_status.h:47: // Deprecated: AUDIO_RENDERER_ERROR_SPLICE_FAILED = 20, Need to ...
4 years, 1 month ago (2016-11-11 00:54:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492953003/60001
4 years, 1 month ago (2016-11-11 02:12:59 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-11 03:50:04 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 03:56:49 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8ae8c69e525729f91c22544659705689765ef58a
Cr-Commit-Position: refs/heads/master@{#431488}

Powered by Google App Engine
This is Rietveld 408576698