Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2492913002: s390: fix overflowing offset in std and ld (Closed)

Created:
4 years, 1 month ago by john.yan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: fix overflowing offset in std and ld use StoreDouble and LoadDouble function to avoid overflowing offset used in std and ld R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/c7ebb14c3cff64ebf4c8844f9bccb2dcedbe213a Cr-Commit-Position: refs/heads/master@{#40907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 13 chunks +26 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 1 month ago (2016-11-10 21:27:50 UTC) #1
JaideepBajwa
lgtm
4 years, 1 month ago (2016-11-10 21:28:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492913002/1
4 years, 1 month ago (2016-11-10 21:28:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 21:55:52 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7ebb14c3cff64ebf4c8844f9bccb2dcedbe213a
Cr-Commit-Position: refs/heads/master@{#40907}

Powered by Google App Engine
This is Rietveld 408576698