Skip queryall_test on canary. See #27794

Skip queryall_test on canary.  See #27794

R=alanknight@google.com

Committed: https://github.com/dart-lang/sdk/commit/588f10ee8e0dc69f13392da607bf1c9a97c6a999

[vsm, 2016-11-10 23:41:17]

vsm@google.com changed reviewers:
+ alanknight@google.com

[vsm, 2016-11-14 17:40:18]

ping

alternatively, we can mark canary as flaky for now.

[Alan Knight, 2016-11-14 18:19:35]

On 2016/11/14 17:40:18, vsm wrote:
> ping
> 
> alternatively, we can mark canary as flaky for now.

How does marking canary as flaky work? In the interests of not accumulating
co19-sized status files full of obsolete suppressions it would be good if we can
do this in a way so that we notice when it gets fixed. And if it doesn't get
fixed and queryAll hangs sometimes in future Chrome versions then we'd want to
know that too.

[vsm, 2016-11-14 18:39:43]

On 2016/11/14 18:19:35, Alan Knight wrote:
> On 2016/11/14 17:40:18, vsm wrote:
> > ping
> > 
> > alternatively, we can mark canary as flaky for now.
> 
> How does marking canary as flaky work? In the interests of not accumulating
> co19-sized status files full of obsolete suppressions it would be good if we
can
> do this in a way so that we notice when it gets fixed. And if it doesn't get
> fixed and queryAll hangs sometimes in future Chrome versions then we'd want to
> know that too.

We can mark it as "allowed to fail" in travis.  In this case, we'd probably want
to test beta as well and make sure it's fixed by then.

It's not clear that the problem is actually queryAll - might be something else
in that test.  But, AFAIK, it's not ever hanging on stable or FF.

[vsm, 2016-11-14 19:05:45]

On 2016/11/14 18:39:43, vsm wrote:
> On 2016/11/14 18:19:35, Alan Knight wrote:
> > On 2016/11/14 17:40:18, vsm wrote:
> > > ping
> > > 
> > > alternatively, we can mark canary as flaky for now.
> > 
> > How does marking canary as flaky work? In the interests of not accumulating
> > co19-sized status files full of obsolete suppressions it would be good if we
> can
> > do this in a way so that we notice when it gets fixed. And if it doesn't get
> > fixed and queryAll hangs sometimes in future Chrome versions then we'd want
to
> > know that too.
> 
> We can mark it as "allowed to fail" in travis.  In this case, we'd probably
want
> to test beta as well and make sure it's fixed by then.
> 
> It's not clear that the problem is actually queryAll - might be something else
> in that test.  But, AFAIK, it's not ever hanging on stable or FF.

Trying a mod to test beta instead of canary:

https://travis-ci.org/dart-lang/sdk/builds/175799961

(Karma calls it "Canary", but we can set the path to whatever.)

[vsm, 2016-11-15 17:35:39]

On 2016/11/14 19:05:45, vsm wrote:
> On 2016/11/14 18:39:43, vsm wrote:
> > On 2016/11/14 18:19:35, Alan Knight wrote:
> > > On 2016/11/14 17:40:18, vsm wrote:
> > > > ping
> > > > 
> > > > alternatively, we can mark canary as flaky for now.
> > > 
> > > How does marking canary as flaky work? In the interests of not
accumulating
> > > co19-sized status files full of obsolete suppressions it would be good if
we
> > can
> > > do this in a way so that we notice when it gets fixed. And if it doesn't
get
> > > fixed and queryAll hangs sometimes in future Chrome versions then we'd
want
> to
> > > know that too.
> > 
> > We can mark it as "allowed to fail" in travis.  In this case, we'd probably
> want
> > to test beta as well and make sure it's fixed by then.
> > 
> > It's not clear that the problem is actually queryAll - might be something
else
> > in that test.  But, AFAIK, it's not ever hanging on stable or FF.
> 
> Trying a mod to test beta instead of canary:
> 
> https://travis-ci.org/dart-lang/sdk/builds/175799961
> 
> (Karma calls it "Canary", but we can set the path to whatever.)

Beta times out occasionally too.  I suspect something got a little slower to put
this on the edge of timing out.  Marking it slow for now.

[Alan Knight, 2016-11-15 17:46:59]

lgtm

[vsm, 2016-11-15 17:49:10]

Description was changed from

==========
Skip queryall_test on canary.  See #27794
==========

to

==========
Skip queryall_test on canary.  See #27794

R=alanknight@google.com

Committed:
https://github.com/dart-lang/sdk/commit/588f10ee8e0dc69f13392da607bf1c9a97c6a999
==========

[vsm, 2016-11-15 17:49:12]

Committed patchset #2 (id:20001) manually as
588f10ee8e0dc69f13392da607bf1c9a97c6a999 (presubmit successful).