Chromium Code Reviews
DescriptionReland of Correct spacing in scroll contents of Ash MD detailed view. (patchset #1 id:1 of https://codereview.chromium.org/2500433002/ )
Reason for revert:
Not relevant to the test failure.
BUG=664428
Original issue's description:
> Revert of Correct spacing in scroll contents of Ash MD detailed view. (patchset #1 id:1 of https://codereview.chromium.org/2484913006/ )
>
> Reason for revert:
> Suspected to cause SystemTrayTest.NullDefaultViewIsNotRecorded (ash_unittests) failure.
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/59826
>
> according to keywords "system" "tray" "views" in the description.
>
> Original issue's description:
> > Correct spacing in scroll contents of Ash MD detailed view.
> >
> > This CL adds 4px vertical spaceing for scroll contents in ScrollContentsViewto
> > ensure that there is a correct padding between top row and scroll contents.
> > This also removes spacing between children in ScrollContentsView to comply with
> > the latest MD design spec.
> >
> > BUG=632102, 663199, 663457, 663461, 663154, 632025, 632115
> > TEST=manually verified the layout.
> >
> > Committed: https://crrev.com/bb150edfa1495353882b799b39e05b0d181bcd9c
> > Cr-Commit-Position: refs/heads/master@{#431480}
>
> TBR=tdanderson@chromium.org,fukino@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=632102, 663199, 663457, 663461, 663154, 632025, 632115
>
> Committed: https://crrev.com/1137d16544665bb926542a25c986f0750433caa3
> Cr-Commit-Position: refs/heads/master@{#431517}
TBR=tdanderson@chromium.org,fukino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632102, 663199, 663457, 663461, 663154, 632025, 632115
Committed: https://crrev.com/7b3c74117576554ff2c044b12e5d8c8937c9d5d7
Cr-Commit-Position: refs/heads/master@{#431548}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||