Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: scripts/slave/recipe_modules/webrtc/api.py

Issue 2492823002: Revert of WebRTC: Add cleanup_symlinks step on all bots. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.types import freeze 5 from recipe_engine.types import freeze
6 from recipe_engine import recipe_api 6 from recipe_engine import recipe_api
7 from . import builders 7 from . import builders
8 from . import steps 8 from . import steps
9 9
10 10
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 'swarming_dimensions', {}).iteritems(): 174 'swarming_dimensions', {}).iteritems():
175 self.m.swarming.set_default_dimension(key, value) 175 self.m.swarming.set_default_dimension(key, value)
176 176
177 def checkout(self, **kwargs): 177 def checkout(self, **kwargs):
178 self._working_dir = self.m.chromium_checkout.get_checkout_dir({}) 178 self._working_dir = self.m.chromium_checkout.get_checkout_dir({})
179 if self._working_dir: 179 if self._working_dir:
180 kwargs.setdefault('cwd', self._working_dir) 180 kwargs.setdefault('cwd', self._working_dir)
181 else: 181 else:
182 self._working_dir = self.m.path['slave_build'] 182 self._working_dir = self.m.path['slave_build']
183 183
184 # Cleanup symlinks if there are any created. 184 # TODO(kjellander): Deploy at all bots once verified working.
185 self.m.python('clean symlinks', 185 if self.mastername == 'client.webrtc.fyi':
186 script=self.resource('cleanup_symlinks.py'), 186 # Cleanup symlinks if there are any created.
187 args=[self._working_dir], 187 self.m.python('clean symlinks',
188 infra_step=True) 188 script=self.resource('cleanup_symlinks.py'),
189 args=[self._working_dir],
190 infra_step=True)
189 191
190 update_step = self.m.bot_update.ensure_checkout(**kwargs) 192 update_step = self.m.bot_update.ensure_checkout(**kwargs)
191 assert update_step.json.output['did_run'] 193 assert update_step.json.output['did_run']
192 194
193 # Whatever step is run right before this line needs to emit got_revision. 195 # Whatever step is run right before this line needs to emit got_revision.
194 revs = update_step.presentation.properties 196 revs = update_step.presentation.properties
195 self.revision = revs['got_revision'] 197 self.revision = revs['got_revision']
196 self.revision_cp = revs['got_revision_cp'] 198 self.revision_cp = revs['got_revision_cp']
197 self.revision_number = str(self.m.commit_position.parse_revision( 199 self.revision_number = str(self.m.commit_position.parse_revision(
198 self.revision_cp)) 200 self.revision_cp))
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 def clean_test_output(self): 379 def clean_test_output(self):
378 """Remove all test output in out/, since we have tests leaking files.""" 380 """Remove all test output in out/, since we have tests leaking files."""
379 out_dir = self.m.path['checkout'].join('out') 381 out_dir = self.m.path['checkout'].join('out')
380 self.m.python('clean test output files', 382 self.m.python('clean test output files',
381 script=self.resource('cleanup_files.py'), 383 script=self.resource('cleanup_files.py'),
382 args=[out_dir], 384 args=[out_dir],
383 infra_step=True) 385 infra_step=True)
384 386
385 def virtual_webcam_check(self): 387 def virtual_webcam_check(self):
386 self.m.python('webcam_check', self.resource('ensure_webcam_is_running.py')) 388 self.m.python('webcam_check', self.resource('ensure_webcam_is_running.py'))
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698