Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 2492793002: Support fetching attribute listeners from outside v8 context scopes. (Closed)
Patch Set: try to tidy up logic Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 if (!listener) 406 if (!listener)
407 return false; 407 return false;
408 return addEventListener(eventType, listener, false); 408 return addEventListener(eventType, listener, false);
409 } 409 }
410 410
411 EventListener* EventTarget::getAttributeEventListener( 411 EventListener* EventTarget::getAttributeEventListener(
412 const AtomicString& eventType) { 412 const AtomicString& eventType) {
413 EventListenerVector* listenerVector = getEventListeners(eventType); 413 EventListenerVector* listenerVector = getEventListeners(eventType);
414 if (!listenerVector) 414 if (!listenerVector)
415 return nullptr; 415 return nullptr;
416
416 for (auto& eventListener : *listenerVector) { 417 for (auto& eventListener : *listenerVector) {
417 EventListener* listener = eventListener.listener(); 418 EventListener* listener = eventListener.listener();
418 if (listener->isAttribute() && listener->belongsToTheCurrentWorld()) 419 if (listener->isAttribute() &&
420 listener->belongsToTheCurrentWorld(getExecutionContext()))
419 return listener; 421 return listener;
420 } 422 }
421 return nullptr; 423 return nullptr;
422 } 424 }
423 425
424 bool EventTarget::clearAttributeEventListener(const AtomicString& eventType) { 426 bool EventTarget::clearAttributeEventListener(const AtomicString& eventType) {
425 EventListener* listener = getAttributeEventListener(eventType); 427 EventListener* listener = getAttributeEventListener(eventType);
426 if (!listener) 428 if (!listener)
427 return false; 429 return false;
428 return removeEventListener(eventType, listener, false); 430 return removeEventListener(eventType, listener, false);
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
756 // they have one less listener to invoke. 758 // they have one less listener to invoke.
757 if (d->firingEventIterators) { 759 if (d->firingEventIterators) {
758 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) { 760 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) {
759 d->firingEventIterators->at(i).iterator = 0; 761 d->firingEventIterators->at(i).iterator = 0;
760 d->firingEventIterators->at(i).end = 0; 762 d->firingEventIterators->at(i).end = 0;
761 } 763 }
762 } 764 }
763 } 765 }
764 766
765 } // namespace blink 767 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698