Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2492783004: [ic] Fix elements conversion in KeyedStoreGeneric (Closed)

Created:
4 years, 1 month ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Fix elements conversion in KeyedStoreGeneric A SmiUntag() was missing when loading the old backing store's length. BUG=chromium:664469 Committed: https://crrev.com/567904f1a784595f606dd855684f25dc4358abeb Cr-Commit-Position: refs/heads/master@{#40921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/ic/keyed-store-generic.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-664469.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Igor Sheludko
lgtm
4 years, 1 month ago (2016-11-11 12:30:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492783004/1
4 years, 1 month ago (2016-11-11 12:32:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 13:01:56 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/567904f1a784595f606dd855684f25dc4358abeb
Cr-Commit-Position: refs/heads/master@{#40921}

Powered by Google App Engine
This is Rietveld 408576698