Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: device/generic_sensor/linux/platform_sensor_utils_linux.cc

Issue 2492773002: [sensors][CrOS/Linux] Implementation of motion sensors for CrOS/Linux platforms (Closed)
Patch Set: comments from Mikhail and Reilly Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/generic_sensor/linux/platform_sensor_utils_linux.h" 5 #include "device/generic_sensor/linux/platform_sensor_utils_linux.h"
6 6
7 #include "base/files/file_enumerator.h" 7 #include "base/files/file_enumerator.h"
8 #include "base/files/file_util.h" 8 #include "base/files/file_util.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
11 #include "base/threading/thread_restrictions.h" 11 #include "base/threading/thread_restrictions.h"
12 #include "device/generic_sensor/linux/sensor_data_linux.h"
13 #include "device/generic_sensor/public/cpp/sensor_reading.h" 12 #include "device/generic_sensor/public/cpp/sensor_reading.h"
14 13
15 namespace device { 14 namespace device {
16 15
17 namespace { 16 namespace {
18 17
19 bool InitSensorPaths(const std::vector<std::string>& input_names, 18 bool InitSensorPaths(const std::vector<std::string>& input_names,
20 const char* base_path, 19 const char* base_path,
21 std::vector<base::FilePath>* sensor_paths) { 20 std::vector<base::FilePath>* sensor_paths) {
22 // Search the iio/devices directory for a subdirectory (eg "device0" or 21 // Search the iio/devices directory for a subdirectory (eg "device0" or
(...skipping 22 matching lines...) Expand all
45 // treated as a non-existing one. 44 // treated as a non-existing one.
46 for (auto const& file_names : data.sensor_file_names) { 45 for (auto const& file_names : data.sensor_file_names) {
47 // Supply InitSensorPaths() with a set of files. 46 // Supply InitSensorPaths() with a set of files.
48 // Only one file from each set should be found. 47 // Only one file from each set should be found.
49 if (!InitSensorPaths(file_names, data.base_path_sensor_linux, sensor_paths)) 48 if (!InitSensorPaths(file_names, data.base_path_sensor_linux, sensor_paths))
50 return false; 49 return false;
51 } 50 }
52 return true; 51 return true;
53 } 52 }
54 53
54 double GetSensorScalingValues(std::string scale_file_name,
Mikhail 2016/11/11 09:07:41 const std::string&
maksims (do not use this acc) 2016/11/11 09:27:45 Done.
55 const base::FilePath& sensor_base_path) {
56 double scaling_value = 1;
57
58 base::FilePath scale_path = sensor_base_path.Append(scale_file_name);
59 if (base::PathExists(scale_path)) {
60 std::string scale;
61 if (!base::ReadFileToString(scale_path, &scale))
62 return scaling_value;
Mikhail 2016/11/11 09:07:41 This looks like a fatal error, we should handle it
maksims (do not use this acc) 2016/11/11 09:27:45 Done.
63 base::TrimWhitespaceASCII(scale, base::TRIM_ALL, &scale);
64
65 if (!base::StringToDouble(scale, &scaling_value))
Mikhail 2016/11/11 09:07:41 Ditto.
maksims (do not use this acc) 2016/11/11 09:27:45 Done.
66 scaling_value = 1;
67 }
68 return scaling_value;
69 }
70
55 } // namespace 71 } // namespace
56 72
57 // static 73 // static
58 std::unique_ptr<SensorReader> SensorReader::Create( 74 std::unique_ptr<SensorReader> SensorReader::Create(
59 const SensorDataLinux& data) { 75 const SensorDataLinux& data) {
60 base::ThreadRestrictions::AssertIOAllowed(); 76 base::ThreadRestrictions::AssertIOAllowed();
61 std::vector<base::FilePath> sensor_paths; 77 std::vector<base::FilePath> sensor_paths;
62 if (!GetSensorFilePaths(data, &sensor_paths)) 78 if (!GetSensorFilePaths(data, &sensor_paths))
63 return nullptr; 79 return nullptr;
64 return base::WrapUnique(new SensorReader(std::move(sensor_paths))); 80
81 DCHECK(!sensor_paths.empty());
82 base::FilePath sensor_base_path = sensor_paths.back().DirName();
83 double scaling_value =
84 GetSensorScalingValues(data.sensor_scale_name.c_str(), sensor_base_path);
Mikhail 2016/11/11 09:07:41 GetSensorScalingValues(data.sensor_scale_name, ..
85
86 return base::WrapUnique(new SensorReader(
87 std::move(sensor_paths), scaling_value, data.apply_scaling_func));
65 } 88 }
66 89
67 SensorReader::SensorReader(std::vector<base::FilePath> sensor_paths) 90 SensorReader::SensorReader(
68 : sensor_paths_(std::move(sensor_paths)) { 91 std::vector<base::FilePath> sensor_paths,
92 double scaling_value,
93 const SensorDataLinux::ReaderFunctor& apply_scaling_func)
94 : sensor_paths_(std::move(sensor_paths)),
95 scaling_value_(scaling_value),
96 apply_scaling_func_(apply_scaling_func) {
69 DCHECK(!sensor_paths_.empty()); 97 DCHECK(!sensor_paths_.empty());
70 } 98 }
71 99
72 SensorReader::~SensorReader() = default; 100 SensorReader::~SensorReader() = default;
73 101
74 bool SensorReader::ReadSensorReading(SensorReading* reading) { 102 bool SensorReader::ReadSensorReading(SensorReading* reading) {
75 base::ThreadRestrictions::AssertIOAllowed(); 103 base::ThreadRestrictions::AssertIOAllowed();
76 SensorReading readings; 104 SensorReading readings;
77 DCHECK_LE(sensor_paths_.size(), arraysize(readings.values)); 105 DCHECK_LE(sensor_paths_.size(), arraysize(readings.values));
78 int i = 0; 106 int i = 0;
79 for (const auto& path : sensor_paths_) { 107 for (const auto& path : sensor_paths_) {
80 std::string new_read_value; 108 std::string new_read_value;
81 if (!base::ReadFileToString(path, &new_read_value)) 109 if (!base::ReadFileToString(path, &new_read_value))
82 return false; 110 return false;
83 111
84 double new_value = 0; 112 double new_value = 0;
85 base::TrimWhitespaceASCII(new_read_value, base::TRIM_ALL, &new_read_value); 113 base::TrimWhitespaceASCII(new_read_value, base::TRIM_ALL, &new_read_value);
86 if (!base::StringToDouble(new_read_value, &new_value)) 114 if (!base::StringToDouble(new_read_value, &new_value))
87 return false; 115 return false;
88 readings.values[i++] = new_value; 116 readings.values[i++] = new_value;
89 } 117 }
118 if (!apply_scaling_func_.is_null())
119 apply_scaling_func_.Run(scaling_value_, readings);
90 *reading = readings; 120 *reading = readings;
91 return true; 121 return true;
92 } 122 }
93 123
94 } // namespace device 124 } // namespace device
OLDNEW
« no previous file with comments | « device/generic_sensor/linux/platform_sensor_utils_linux.h ('k') | device/generic_sensor/linux/sensor_data_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698