Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2492763002: Make WebView keep keyboard when losing focus (2nd cherrypick) (Closed)

Created:
4 years, 1 month ago by aelias_dont_use
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Make WebView keep keyboard when losing focus (2nd cherrypick) WebView should not hide keyboard when losing focus. As for Chrome, it should keep current behavior. These cases include when the ContentView is hidden (closing current tab, opening a new tab, switching to an existing tab), and when imeAdapter is attached to its native counterpart(navigation). Note that this CL will change one behavior of Chrome: keyboard will not be hidden when focus moves from ContentView to UrlBar. BUG=636237 Review-Url: https://codereview.chromium.org/2290133002 Cr-Commit-Position: refs/heads/master@{#429531} Committed: https://chromium.googlesource.com/chromium/src/+/af689b896e2307286cc6b82b2728fe16b483f897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -77 lines) Patch
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 3 chunks +2 lines, -1 line 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreFocusTest.java View 1 chunk +0 lines, -75 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_dont_use
4 years, 1 month ago (2016-11-10 06:47:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af689b896e2307286cc6b82b2728fe16b483f897.

Powered by Google App Engine
This is Rietveld 408576698