Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2492753002: [WIP] [url_utils] Implement a contiguous SchemeSet to replace vector<SchemeWithType>

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[url_utils] Implement a contiguous SchemeSet to replace vector<SchemeWithType> This speeds up DoIsStandard by ~5x. This function is called from all sorts of places, in both the browser process and renderer process. A single load of facebook.com on desktop yielded around 17k of these calls. As a followup, we should wrap SchemeSet in Blink and use it for the SchemeRegistry there (which is currently just using a map). BUG=664174, 348655

Patch Set 1 #

Patch Set 2 : separate SchemeSet for blink migration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -48 lines) Patch
M url/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A url/scheme_set.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
A url/scheme_set.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M url/url_util.cc View 1 12 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 11 (11 generated)
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-10 06:03:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492753002/1
4 years, 1 month ago (2016-11-10 06:04:05 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-10 07:06:44 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 1 month ago (2016-11-10 07:06:45 UTC) #4
Charlie Harrison
Description was changed from ========== [url_utils] Implement ContiguousSchemeSet to replace vector<SchemeWithType> BUG= ========== to ========== ...
4 years, 1 month ago (2016-11-10 18:49:51 UTC) #5
Charlie Harrison
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
4 years ago (2016-11-29 19:56:04 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492753002/20001
4 years ago (2016-11-29 19:56:24 UTC) #7
Charlie Harrison
Description was changed from ========== [url_utils] Implement ContiguousSchemeSet to replace vector<SchemeWithType> This speeds up DoIsStandard ...
4 years ago (2016-11-29 20:00:55 UTC) #8
Charlie Harrison
Description was changed from ========== [url_utils] Implement a contiguous SchemeSet to replace vector<SchemeWithType> This speeds ...
4 years ago (2016-11-29 20:54:01 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-11-29 22:24:47 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 22:24:48 UTC) #11
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698