Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2492713006:
Fix size regression: Make non-public deps (Closed)
|
Created:
4 years, 1 month ago by Fady Samuel Modified:
4 years, 1 month ago Reviewers:
piman CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix size regression: Make non-public deps
Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a
DLL size regression. I'm guessing that's because I made the deps public_deps on the
new targets. I've changed them back to deps. Hopefully that addresses the issue.
BUG=664481
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/03f92f188350dd41ffb806b959b885d49a63f639
Cr-Commit-Position: refs/heads/master@{#431560}
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Fix size regression: Make non-public deps BUG=664481 ========== to ========== Fix size regression: Make non-public deps BUG=664481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Fix size regression: Make non-public deps BUG=664481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
fsamuel@chromium.org changed reviewers: + piman@chromium.org
The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 TBR=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Antoine, I've TBR'ed you and I'm going to go ahead and land this CL. It's just a couple of public_deps => deps and all bots are happy.
The CQ bit was checked by fsamuel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 TBR=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 TBR=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 TBR=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix size regression: Make non-public deps Mus: Move InProcessCommandBuffer and GLInProcessContext to gpu/ipc caused a DLL size regression. I'm guessing that's because I made the deps public_deps on the new targets. I've changed them back to deps. Hopefully that addresses the issue. BUG=664481 TBR=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/03f92f188350dd41ffb806b959b885d49a63f639 Cr-Commit-Position: refs/heads/master@{#431560} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/03f92f188350dd41ffb806b959b885d49a63f639 Cr-Commit-Position: refs/heads/master@{#431560}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
