Third try at landing gRPC refactoring. Previous issue failed on the waterfall

Third try at landing gRPC refactoring. Previous iteration failed on opt builds because it did work inside a DCHECK().

Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset … (patchset #5 id:100001 of https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462
Committed: https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a
Cr-Commit-Position: refs/heads/master@{#431366}

[Garrett Casto, 2016-11-10 00:46:09]

Description was changed from

==========
Third try at landing gRPC refactoring. Previous issue failed on the waterfall
(e.g.
https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%...,
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...).
This CL tries to address this by calling
base::Thread::WaitUntilThreadStarted() before calling
base::Thread::task_runner(). It's not clear
if task_runner() can return nullptr before


Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet
and into a new component. (patchset … (patchset #5 id:100001 of
https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462
==========

to

==========
Third try at landing gRPC refactoring. Previous issue failed on the waterfall
(e.g.
https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%...,
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...).
Looks like the task_runner_ in BidirectionalStreamTestURLRequestContextGetter is
null. This CL tries to address this by calling
base::Thread::WaitUntilThreadStarted() before calling
base::Thread::task_runner().


Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet
and into a new component. (patchset … (patchset #5 id:100001 of
https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462
==========

[Garrett Casto, 2016-11-10 00:46:26]

gcasto@chromium.org changed reviewers:
+ mef@chromium.org

[Garrett Casto, 2016-11-10 00:56:09]

Patchset #1 (id:1) has been deleted

[Garrett Casto, 2016-11-10 01:04:40]

On 2016/11/10 00:56:09, Garrett Casto wrote:
> Patchset #1 (id:1) has been deleted

As before, first patchset is just the revert, second is the addition. As I
mentioned out of band, I don't know for certain that this fixes the problem
since I can't reproduce it. From looking at the code it's not clear to me that
it's possible for base::Thread::message_loop_ to ever be null after Start() has
been called, but it's the only possibility that I can see.

[Garrett Casto, 2016-11-10 06:24:14]

Description was changed from

==========
Third try at landing gRPC refactoring. Previous issue failed on the waterfall
(e.g.
https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%...,
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...).
Looks like the task_runner_ in BidirectionalStreamTestURLRequestContextGetter is
null. This CL tries to address this by calling
base::Thread::WaitUntilThreadStarted() before calling
base::Thread::task_runner().


Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet
and into a new component. (patchset … (patchset #5 id:100001 of
https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462
==========

to

==========
Third try at landing gRPC refactoring. Previous iteration failed on opt builds
because it did work inside a DCHECK().

Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet
and into a new component. (patchset … (patchset #5 id:100001 of
https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462
==========

[Garrett Casto, 2016-11-10 06:27:09]

On 2016/11/10 01:04:40, Garrett Casto wrote:
> On 2016/11/10 00:56:09, Garrett Casto wrote:
> > Patchset #1 (id:1) has been deleted
> 
> As before, first patchset is just the revert, second is the addition. As I
> mentioned out of band, I don't know for certain that this fixes the problem
> since I can't reproduce it. From looking at the code it's not clear to me that
> it's possible for base::Thread::message_loop_ to ever be null after Start()
has
> been called, but it's the only possibility that I can see.

It turns out that the answer was rather simple, the previous code did
DCHECK(thread->StartWithOptions()), which obviously failed when DCHECK was
disabled. I'm going to follow up on chromium-dev as to why the CQ doesn't
include any bot which checks this, but this CL should now actually fix the
problem. PTAL.

[blundell, 2016-11-10 08:27:26]

lgtm

I think that all of CQ's bots run in release+DCHECK mode.

[mef, 2016-11-10 16:16:18]

lgtm. I've tried it on Android Release build and can confirm that I see the
crash without the fix and see tests pass with the fix.

[Garrett Casto, 2016-11-10 20:40:15]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2016-11-10 20:40:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:45:29]

Description was changed from

==========
Third try at landing gRPC refactoring. Previous iteration failed on opt builds
because it did work inside a DCHECK().

Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet
and into a new component. (patchset … (patchset #5 id:100001 of
https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462
==========

to

==========
Third try at landing gRPC refactoring. Previous iteration failed on opt builds
because it did work inside a DCHECK().

Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet
and into a new component. (patchset … (patchset #5 id:100001 of
https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462
==========

[commit-bot: I haz the power, 2016-11-10 21:45:30]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-10 22:34:43]

Description was changed from

==========
Third try at landing gRPC refactoring. Previous iteration failed on opt builds
because it did work inside a DCHECK().

Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet
and into a new component. (patchset … (patchset #5 id:100001 of
https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462
==========

to

==========
Third try at landing gRPC refactoring. Previous iteration failed on opt builds
because it did work inside a DCHECK().

Revert "Revert of Revert "Revert of Moving gRPC support interfaces out of cronet
and into a new component. (patchset … (patchset #5 id:100001 of
https://codereview.chromium.org/2470923002/ )"

This reverts commit f42bc4c56bd255e293109de16b8d19b7adcdc889.

TBR=blundell@chromium.org
BUG=650462

Committed: https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a
Cr-Commit-Position: refs/heads/master@{#431366}
==========

[commit-bot: I haz the power, 2016-11-10 22:34:45]

Patchset 3 (id:??) landed as
https://crrev.com/67ace9323db6baf5d3177ebb243fdcd07d11486a
Cr-Commit-Position: refs/heads/master@{#431366}