Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2492633002: Create AST structure for asserts in constructor initializers (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson
Modified:
4 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create AST structure for asserts in constructor initializers R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3c437f5d9e3b2cefd581d34f08d8ab4484bea608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -42 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 4 chunks +46 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/dart/ast/visitor.dart View 5 chunks +23 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 2 chunks +88 lines, -16 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 6 chunks +68 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +14 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 1 month ago (2016-11-09 21:22:11 UTC) #2
scheglov
LGTM
4 years, 1 month ago (2016-11-09 21:29:19 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-11-10 17:00:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c437f5d9e3b2cefd581d34f08d8ab4484bea608 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698