Implementation for feature policy - vibrate.

third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  *  Library General Public License for more details.
  *
  *  You should have received a copy of the GNU Library General Public License
  *  along with this library; see the file COPYING.LIB.  If not, write to
  *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  *  Boston, MA 02110-1301, USA.
  */
 
 #include "modules/vibration/NavigatorVibration.h"
 
+#include "bindings/core/v8/ConditionalFeatures.h"
 #include "core/dom/Document.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Navigator.h"
 #include "core/frame/UseCounter.h"
 #include "core/page/Page.h"
 #include "modules/vibration/VibrationController.h"
 #include "platform/Histogram.h"
 #include "platform/UserGestureIndicator.h"
 
@@ skipping 38 matching lines @@
   if (!frame)
     return false;
   collectHistogramMetrics(*frame);
 
   DCHECK(frame->document());
   DCHECK(frame->page());
 
   if (!frame->page()->isPageVisible())
     return false;
 
-  if (frame->isCrossOriginSubframe()) {
-    // TODO(binlu): Once FeaturePolicy is ready, exploring using it to
-    // remove the API instead of having it return false.
+  // TODO(lunalu): When FeaturePolicy is ready, take out the check for the
+  // runtime flag.
+  if (RuntimeEnabledFeatures::featurePolicyEnabled()) {
+    if (!isFeatureEnabledInFrame(blink::kVibrateFeature, frame)) {
+      frame->localDOMWindow()->printErrorMessage(
+          "Navigator.vibrate() is not enabled in feature policy for this "
+          "frame.");
+      return false;
+    }
+  } else if (frame->isCrossOriginSubframe()) {
     frame->localDOMWindow()->printErrorMessage(
         "A call of navigator.vibrate will be no-op inside cross-origin "
         "iframes: https://www.chromestatus.com/feature/5682658461876224.");
     return false;
   }

[raymes, 2016/11/16 23:21:07]

nit: Should we rework this so that only the error message is dependent on
whether FP is enabled? I think it would reuse a little more logic. e.g.

if (!isFeatureEnabledInFrame(blink::kVibrateFeature, frame)) {
  if (RuntimeEnabledFeatures::featurePolicyEnabled())
    frame->localDOMWindow()->printErrorMessage(...);
  else
    frame->localDOMWindow()->printErrorMessage(...);
  return false
}

[lunalu1, 2016/11/17 21:47:20]

Done.

 
   return NavigatorVibration::from(navigator).controller(*frame)->vibrate(
       pattern);
 }
 
 // static
 void NavigatorVibration::collectHistogramMetrics(const LocalFrame& frame) {
   NavigatorVibrationType type;
   bool userGesture = UserGestureIndicator::processingUserGesture();
   UseCounter::count(&frame, UseCounter::NavigatorVibrate);
@@ skipping 35 matching lines @@
   }
 }
 
 DEFINE_TRACE(NavigatorVibration) {
   visitor->trace(m_controller);
   Supplement<Navigator>::trace(visitor);
   ContextLifecycleObserver::trace(visitor);
 }
 
 }  // namespace blink