Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: gpu/ipc/service/image_transport_surface_mac.mm

Issue 2492583002: Decouple PassThroughImageTransportSurface from GpuCommandBufferStub (Closed)
Patch Set: Addressed Antoine's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/ipc/service/image_transport_surface_mac.mm
diff --git a/gpu/ipc/service/image_transport_surface_mac.mm b/gpu/ipc/service/image_transport_surface_mac.mm
index 8752aad81556e6ee80a9e3aef1ccc4c686f3d22e..e5f4717e38e513f80d8b227b529e9185d5d70e47 100644
--- a/gpu/ipc/service/image_transport_surface_mac.mm
+++ b/gpu/ipc/service/image_transport_surface_mac.mm
@@ -42,7 +42,7 @@ bool g_allow_os_mesa = false;
// static
scoped_refptr<gl::GLSurface> ImageTransportSurface::CreateNativeSurface(
GpuChannelManager* manager,
- GpuCommandBufferStub* stub,
+ base::WeakPtr<ImageTransportSurfaceDelegate> delegate,
SurfaceHandle surface_handle,
gl::GLSurface::Format format) {
DCHECK_NE(surface_handle, kNullSurfaceHandle);
@@ -52,7 +52,7 @@ scoped_refptr<gl::GLSurface> ImageTransportSurface::CreateNativeSurface(
case gl::kGLImplementationDesktopGLCoreProfile:
case gl::kGLImplementationAppleGL:
return make_scoped_refptr<gl::GLSurface>(
- new ImageTransportSurfaceOverlayMac(stub));
+ new ImageTransportSurfaceOverlayMac(delegate));
case gl::kGLImplementationMockGL:
return make_scoped_refptr<gl::GLSurface>(new gl::GLSurfaceStub);
default:
@@ -67,7 +67,7 @@ scoped_refptr<gl::GLSurface> ImageTransportSurface::CreateNativeSurface(
if (!surface.get() || !surface->Initialize(format))
return surface;
return make_scoped_refptr<gl::GLSurface>(
- new PassThroughImageTransportSurface(stub, surface.get()));
+ new PassThroughImageTransportSurface(delegate, surface.get()));
}
}
« no previous file with comments | « gpu/ipc/service/image_transport_surface_linux.cc ('k') | gpu/ipc/service/image_transport_surface_overlay_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698