Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2492573002: Add an option to build with the 10.0.14393 SDK (Closed)

Created:
4 years, 1 month ago by brucedawson
Modified:
4 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an option to build with the 10.0.14393 SDK At some point we may need to build with the 10.0.14393 (Windows 10 Anniversary Edition) SDK. It's all packaged up and ready to go, and this is as good a way as any to record what the hash is for when we need it. Any Google employee developing Chrome on Windows can test this out by setting DEPOT_TOOLS_WIN_SDK_PRERELEASE=1 and running gclient runhooks. BUG=440500 Committed: https://crrev.com/5456b380fd8b29d954ad293c19d13b18b975f166 Cr-Commit-Position: refs/heads/master@{#431387}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/vs_toolchain.py View 1 chunk +6 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
brucedawson
Might as well make this available for testing purposes? That way we'll be more clearly ...
4 years, 1 month ago (2016-11-10 01:19:11 UTC) #2
scottmg
lgtm https://codereview.chromium.org/2492573002/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/2492573002/diff/1/build/vs_toolchain.py#newcode314 build/vs_toolchain.py:314: else: Maybe delete the 2013 hash while you're ...
4 years, 1 month ago (2016-11-10 01:30:01 UTC) #3
brucedawson
> Maybe delete the 2013 hash while you're at it. I'm inclined to leave it ...
4 years, 1 month ago (2016-11-10 21:51:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492573002/1
4 years, 1 month ago (2016-11-10 21:53:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 22:57:47 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 23:10:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5456b380fd8b29d954ad293c19d13b18b975f166
Cr-Commit-Position: refs/heads/master@{#431387}

Powered by Google App Engine
This is Rietveld 408576698