Allow PasswordCredential instantiation when an input element has multiple 'autocomplete' tokens.

third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/credentialmanager/PasswordCredential.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/HTMLNames.h"
 #include "core/dom/ExecutionContext.h"
@@ skipping 46 matching lines @@
   AtomicString idName;
   AtomicString passwordName;
   for (FormAssociatedElement* element : form->associatedElements()) {
     // If |element| isn't a "submittable element" with string data, then it
     // won't have a matching value in |formData|, and we can safely skip it.
     FileOrUSVString result;
     formData->get(element->name(), result);
     if (!result.isUSVString())
       continue;
 
-    AtomicString autocomplete =
-        toHTMLElement(element)->fastGetAttribute(HTMLNames::autocompleteAttr);
-    if (equalIgnoringCase(autocomplete, "current-password") ||
-        equalIgnoringCase(autocomplete, "new-password")) {
+    Vector<String> autofillTokens;
+    toHTMLElement(element)
+        ->fastGetAttribute(HTMLNames::autocompleteAttr)
+        .getString()
+        .split(' ', autofillTokens);
+    auto hasToken = [&autofillTokens](const StringView& expectedToken) {

[haraken, 2016/11/10 02:01:51]

Nit: The lambda function is allowed in the style guide but is not commonly used
in Blink. I'd prefer using a simple helper function.

[Mike West, 2016/11/10 07:46:39]

It also seems like it would be more efficient to loop through the list once
rather than once for each token we care about. That is, I'd prefer something
like:

```
toHTMLElement(element)
        ->fastGetAttribute(HTMLNames::autocompleteAttr)
        .getString()
        .lower() // Lowercase here once to avoid the case-folding logic below
        .split(' ', autofillTokens);
for (const auto& token : autofillTokens) {
  if (token == "current-password" || token == "new-password") {
    ...
  } else if (...) {
    ...
  }
}
```

[vasilii, 2016/11/10 09:21:55]

Done.

+      for (const auto& token : autofillTokens) {
+        if (equalIgnoringASCIICase(token, expectedToken))
+          return true;
+      }
+      return false;
+    };
+    if (hasToken("current-password") || hasToken("new-password")) {
       data.setPassword(result.getAsUSVString());
       passwordName = element->name();
-    } else if (equalIgnoringCase(autocomplete, "photo")) {
+    } else if (hasToken("photo")) {
       data.setIconURL(result.getAsUSVString());
-    } else if (equalIgnoringCase(autocomplete, "name") ||
-               equalIgnoringCase(autocomplete, "nickname")) {
+    } else if (hasToken("name") || hasToken("nickname")) {
       data.setName(result.getAsUSVString());
-    } else if (equalIgnoringCase(autocomplete, "username")) {
+    } else if (hasToken("username")) {
       data.setId(result.getAsUSVString());
       idName = element->name();
     }
   }
 
   // Create a PasswordCredential using the data gathered above.
   PasswordCredential* credential =
       PasswordCredential::create(data, exceptionState);
   if (exceptionState.hadException())
     return nullptr;
@@ skipping 86 matching lines @@
   return static_cast<PlatformPasswordCredential*>(m_platformCredential.get())
       ->password();
 }
 
 DEFINE_TRACE(PasswordCredential) {
   SiteBoundCredential::trace(visitor);
   visitor->trace(m_additionalData);
 }
 
 }  // namespace blink