Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 249253003: Hide SaveFlags from the public SkCanvas API. (Closed)

Created:
6 years, 8 months ago by f(malita)
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Hide SaveFlags from the public SkCanvas API. After removing most internal and external (non-Android) users, this is finally tractable - but not pretty by any stretch of imagination. Android still needs to support the old API - hence the guard (SK_SUPPORT_LEGACY_SAVEFLAGS). R=reed@google.com,robertphillips@google.com,mtklein@google.com,scroggo@google.com

Patch Set 1 #

Patch Set 2 : Suppress the canvas-state GM. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -39 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gm/canvasstate.cpp View 4 chunks +23 lines, -8 lines 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 8 chunks +26 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +29 lines, -3 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/effects/SkBlurDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pipe/SkGPipeRead.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M src/record/SkRecordDraw.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/record/SkRecordOpts.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/record/SkRecorder.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M src/record/SkRecords.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 3 chunks +12 lines, -5 lines 0 comments Download
M src/utils/debugger/SkObjectParser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CanvasTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
f(malita)
I'm torn on this one: supporting both code paths could be too much of a ...
6 years, 8 months ago (2014-04-23 16:45:18 UTC) #1
scroggo
6 years, 8 months ago (2014-04-23 17:52:21 UTC) #2
On 2014/04/23 16:45:18, Florin Malita wrote:
> I'm torn on this one: supporting both code paths could be too much of a burden
> going forward.
> 
> Maybe we can simply mark the old API for deprecation and wait for clients to
> transition: https://codereview.chromium.org/246023008/

Is there a plan for transitioning Android? skbug.com/2440 tracks part of the
problem:
providing another way to get the behavior from
SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG. We
also need to do something to support Canvas.java's save/saveLayer with flags API
(or
convince them to deprecate, which they seem to be hesitant to do - see
https://googleplex-android-review.git.corp.google.com/#/c/439622/).

Powered by Google App Engine
This is Rietveld 408576698