Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 2492523007: Revert of [compiler] Fix flipped boolean checks in marked tier-up (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] Fix flipped boolean checks in marked tier-up (patchset #7 id:120001 of https://codereview.chromium.org/2478323002/ ) Reason for revert: Breaks deopt fuzzer: https://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/14872/steps/Deopt%20Fuzz%20on%20Ubuntu-12.04/logs/stdio Original issue's description: > [compiler] Fix flipped boolean checks in marked tier-up > > Fixes incorrect checks for handle validity when checking the compiled > code, as well as incorrect uses of tst in arm and ppc flag checking > code. Also adds a test that the tier-up works correctly. TBR=rmcilroy@chromium.org,leszeks@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/bad42b387f5b97b6c3ab578d7893ae1fb45c19a8 Cr-Commit-Position: refs/heads/master@{#40919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -113 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D test/mjsunit/shared-function-tier-up-default.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/mjsunit/shared-function-tier-up-ignition.js View 1 chunk +0 lines, -41 lines 0 comments Download
D test/mjsunit/shared-function-tier-up-turbo.js View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Benedikt Meurer
Created Revert of [compiler] Fix flipped boolean checks in marked tier-up
4 years, 1 month ago (2016-11-11 12:38:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492523007/1
4 years, 1 month ago (2016-11-11 12:39:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 12:39:28 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bad42b387f5b97b6c3ab578d7893ae1fb45c19a8
Cr-Commit-Position: refs/heads/master@{#40919}

Powered by Google App Engine
This is Rietveld 408576698