DevTools: throttle calls to ToolbarMenuButton.trigger() to avoid bad context menu state on Mac

DevTools: throttle calls to ToolbarMenuButton.trigger() to avoid bad context menu state on Mac

WI.ToolbarMenuButton shows a real (not-soft) contextMenu on click. It is
possible to reach a bad state on Mac OS by focusing on a different window, then
making two fast clicks on a ToolbarMenuButton (e.g. 3 dot drawer menu) in the
originally unfocused DevTools. On the first mouse press, nothing happens, but on
the second, two mousedown events are sent within 300ms of each other. The
context menu starts to open, but is cleared almost immediately afterwards. After
that, the button no longer shows context menus.

Showing a real context menu on click only happens on ToolbarMenuButton, and
throttling its trigger function will fix the symptom. The core issue is tracked
at crbug.com/661766.

BUG=655556
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2469813005
Cr-Commit-Position: refs/heads/master@{#429498}
(cherry picked from commit b231468fd5825415fff761c25f561c8c782ab25c)

[luoe, 2016-11-09 18:51:51]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org, kozyatinskiy@chromium.org

[luoe, 2016-11-09 18:53:34]

This CL was made for a merge to M55.  Since I don't have committer status, it
needs an l g t m.

No conflicts except for the reformatting to es6 style change.

[luoe, 2016-11-09 18:53:40]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[luoe, 2016-11-09 18:53:54]

Description was changed from

==========
DevTools: throttle calls to ToolbarMenuButton.trigger() to avoid bad context
menu state on Mac

WI.ToolbarMenuButton shows a real (not-soft) contextMenu on click. It is
possible to reach a bad state on Mac OS by focusing on a different window, then
making two fast clicks on a ToolbarMenuButton (e.g. 3 dot drawer menu) in the
originally unfocused DevTools. On the first mouse press, nothing happens, but on
the second, two mousedown events are sent within 300ms of each other. The
context menu starts to open, but is cleared almost immediately afterwards. After
that, the button no longer shows context menus.

Showing a real context menu on click only happens on ToolbarMenuButton, and
throttling its trigger function will fix the symptom. The core issue is tracked
at crbug.com/661766.

BUG=655556

Review-Url: https://codereview.chromium.org/2469813005
Cr-Commit-Position: refs/heads/master@{#429498}
(cherry picked from commit b231468fd5825415fff761c25f561c8c782ab25c)
==========

to

==========
DevTools: throttle calls to ToolbarMenuButton.trigger() to avoid bad context
menu state on Mac

WI.ToolbarMenuButton shows a real (not-soft) contextMenu on click. It is
possible to reach a bad state on Mac OS by focusing on a different window, then
making two fast clicks on a ToolbarMenuButton (e.g. 3 dot drawer menu) in the
originally unfocused DevTools. On the first mouse press, nothing happens, but on
the second, two mousedown events are sent within 300ms of each other. The
context menu starts to open, but is cleared almost immediately afterwards. After
that, the button no longer shows context menus.

Showing a real context menu on click only happens on ToolbarMenuButton, and
throttling its trigger function will fix the symptom. The core issue is tracked
at crbug.com/661766.

BUG=655556
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2469813005
Cr-Commit-Position: refs/heads/master@{#429498}
(cherry picked from commit b231468fd5825415fff761c25f561c8c782ab25c)
==========

[commit-bot: I haz the power, 2016-11-09 18:54:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 18:54:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 18:54:14]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-09 18:59:19]

lgtm

[kozy, 2016-11-09 18:59:59]

lgtm

[luoe, 2016-11-09 19:01:06]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-11-09 19:01:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 19:06:45]

Description was changed from

==========
DevTools: throttle calls to ToolbarMenuButton.trigger() to avoid bad context
menu state on Mac

WI.ToolbarMenuButton shows a real (not-soft) contextMenu on click. It is
possible to reach a bad state on Mac OS by focusing on a different window, then
making two fast clicks on a ToolbarMenuButton (e.g. 3 dot drawer menu) in the
originally unfocused DevTools. On the first mouse press, nothing happens, but on
the second, two mousedown events are sent within 300ms of each other. The
context menu starts to open, but is cleared almost immediately afterwards. After
that, the button no longer shows context menus.

Showing a real context menu on click only happens on ToolbarMenuButton, and
throttling its trigger function will fix the symptom. The core issue is tracked
at crbug.com/661766.

BUG=655556
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2469813005
Cr-Commit-Position: refs/heads/master@{#429498}
(cherry picked from commit b231468fd5825415fff761c25f561c8c782ab25c)
==========

to

==========
DevTools: throttle calls to ToolbarMenuButton.trigger() to avoid bad context
menu state on Mac

WI.ToolbarMenuButton shows a real (not-soft) contextMenu on click. It is
possible to reach a bad state on Mac OS by focusing on a different window, then
making two fast clicks on a ToolbarMenuButton (e.g. 3 dot drawer menu) in the
originally unfocused DevTools. On the first mouse press, nothing happens, but on
the second, two mousedown events are sent within 300ms of each other. The
context menu starts to open, but is cleared almost immediately afterwards. After
that, the button no longer shows context menus.

Showing a real context menu on click only happens on ToolbarMenuButton, and
throttling its trigger function will fix the symptom. The core issue is tracked
at crbug.com/661766.

BUG=655556
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2469813005
Cr-Commit-Position: refs/heads/master@{#429498}
(cherry picked from commit b231468fd5825415fff761c25f561c8c782ab25c)
==========

[commit-bot: I haz the power, 2016-11-09 19:06:49]

Committed patchset #1 (id:1)