Move Insert/SignalSyncPoint() to GpuControl

gpu/command_buffer/service/in_process_command_buffer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/in_process_command_buffer.h"
 
 #include <queue>
 #include <utility>
 
 #include <GLES2/gl2.h>
@@ skipping 621 matching lines @@
                                   id);
 
   QueueTask(task);
 }
 
 gpu::Buffer InProcessCommandBuffer::GetTransferBuffer(int32 id) {
   NOTREACHED();
   return gpu::Buffer();
 }
 
-uint32 InProcessCommandBuffer::InsertSyncPoint() {
-  NOTREACHED();
-  return 0;
-}
-void InProcessCommandBuffer::SignalSyncPoint(unsigned sync_point,
-                                             const base::Closure& callback) {
-  CheckSequencedThread();
-  QueueTask(WrapCallback(callback));
-}
-
 bool InProcessCommandBuffer::SupportsGpuMemoryBuffer() {
   return supports_gpu_memory_buffer_;
 }
 
 gfx::GpuMemoryBuffer* InProcessCommandBuffer::CreateGpuMemoryBuffer(
     size_t width,
     size_t height,
     unsigned internalformat,
     int32* id) {
   CheckSequencedThread();
   base::AutoLock lock(command_buffer_lock_);
   return gpu_control_->CreateGpuMemoryBuffer(width,
                                              height,
                                              internalformat,
                                              id);
 }
 
 void InProcessCommandBuffer::DestroyGpuMemoryBuffer(int32 id) {
   CheckSequencedThread();
   base::Closure task = base::Bind(&GpuControl::DestroyGpuMemoryBuffer,
                                   base::Unretained(gpu_control_.get()),
                                   id);
 
   QueueTask(task);
 }
 
+uint32 InProcessCommandBuffer::InsertSyncPoint() {
+  NOTREACHED();

[piman, 2013/09/27 01:35:47]

If you want to merge the WGC3D implementations and have them delegate to the
GLES2Implementation, this would be reached (though it can still return 0).

It'd be nice to do with this patch, I think, just fixing
WebGraphicsContext3DInProcessCommandBufferImpl::insertSyncPoint to
DELEGATE_TO_GL instead.

+  return 0;
+}
+
+void InProcessCommandBuffer::SignalSyncPoint(unsigned sync_point,
+                                             const base::Closure& callback) {
+  CheckSequencedThread();
+  QueueTask(WrapCallback(callback));
+}
+
 gpu::error::Error InProcessCommandBuffer::GetLastError() {
   CheckSequencedThread();
   return last_state_.error;
 }
 
 bool InProcessCommandBuffer::Initialize() {
   NOTREACHED();
   return false;
 }
 
@@ skipping 68 matching lines @@
   g_gpu_queue.Get().RunTasks();
 }
 
 // static
 void InProcessCommandBuffer::SetGpuMemoryBufferFactory(
     GpuMemoryBufferFactory* factory) {
   g_gpu_memory_buffer_factory = factory;
 }
 
 }  // namespace gpu