Move Insert/SignalSyncPoint() to GpuControl

content/common/gpu/client/command_buffer_proxy_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/command_buffer_proxy_impl.h"
 
 #include "base/callback.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/memory/shared_memory.h"
@@ skipping 415 matching lines @@
 
 uint32 CommandBufferProxyImpl::InsertSyncPoint() {
   if (last_state_.error != gpu::error::kNoError)
     return 0;
 
   uint32 sync_point = 0;
   Send(new GpuCommandBufferMsg_InsertSyncPoint(route_id_, &sync_point));
   return sync_point;
 }
 
-bool CommandBufferProxyImpl::SignalSyncPoint(uint32 sync_point,
+void CommandBufferProxyImpl::SignalSyncPoint(uint32 sync_point,
                                              const base::Closure& callback) {
-  if (last_state_.error != gpu::error::kNoError) {
-    return false;
-  }
+  if (last_state_.error != gpu::error::kNoError)
+    return;
 
   uint32 signal_id = next_signal_id_++;
   if (!Send(new GpuCommandBufferMsg_SignalSyncPoint(route_id_,
                                                     sync_point,
                                                     signal_id))) {
-    return false;
+    return;

[no sievers, 2013/09/27 18:13:04]

We might want to revisit the behavior and always guarantee signal callbacks to
be run. Seems a bit hard otherwise for the client not to potentially deadlock,
esp. if you don't know whether it will run or not (no error returned). But I
guess it's consistent for now (we don't run them in the destructor).

   }
 
   signal_tasks_.insert(std::make_pair(signal_id, callback));
-
-  return true;
 }
 
 bool CommandBufferProxyImpl::SignalQuery(unsigned query,
                                          const base::Closure& callback) {
   if (last_state_.error != gpu::error::kNoError) {
     return false;
   }
 
   // Signal identifiers are hidden, so nobody outside of this class will see
   // them. (And thus, they cannot save them.) The IDs themselves only last
@@ skipping 122 matching lines @@
 void CommandBufferProxyImpl::SendManagedMemoryStats(
     const GpuManagedMemoryStats& stats) {
   if (last_state_.error != gpu::error::kNoError)
     return;
 
   Send(new GpuCommandBufferMsg_SendClientManagedMemoryStats(route_id_,
                                                             stats));
 }
 
 }  // namespace content