Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2492463004: [NTP] Correct the Offline Badge shown on tiles. (Closed)

Created:
4 years, 1 month ago by PEConn
Modified:
4 years, 1 month ago
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Correct the Offline Badge shown on tiles. BUG=663702 Committed: https://crrev.com/1a74fcfbafb42fff45822fe206ba291bc8533701 Cr-Commit-Position: refs/heads/master@{#431266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/res/drawable/offline_badge_background.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/most_visited_item.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
PEConn
PTAL.
4 years, 1 month ago (2016-11-10 15:14:14 UTC) #3
PEConn
PTAL.
4 years, 1 month ago (2016-11-10 15:14:14 UTC) #4
Michael van Ouwerkerk
lgtm
4 years, 1 month ago (2016-11-10 15:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492463004/1
4 years, 1 month ago (2016-11-10 15:24:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 16:02:59 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 16:05:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a74fcfbafb42fff45822fe206ba291bc8533701
Cr-Commit-Position: refs/heads/master@{#431266}

Powered by Google App Engine
This is Rietveld 408576698