Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2492453002: Erasure fix: Replace type parameters with dynamic instead of Object. (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Erasure fix: Replace type parameters with dynamic instead of Object. Using Object causes issues in function types. This fixes an issue for running delta-blue in AOT strong mode. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/kernel/commit/b838af037b56a2065b5997d71d20ee4283c369c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M lib/transformations/erasure.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
4 years, 1 month ago (2016-11-09 13:52:09 UTC) #3
Kevin Millikin (Google)
lgtm
4 years, 1 month ago (2016-11-09 14:57:24 UTC) #4
asgerf
4 years, 1 month ago (2016-11-14 09:11:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b838af037b56a2065b5997d71d20ee4283c369c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698