Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2492433002: [heap] Tracer: Eliminate prefix for external callbacks (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Tracer: Eliminate prefix for external callbacks The distinction didn't provide any benefits. BUG=chromium:651354 Committed: https://crrev.com/8d6de5f2ec25b303c7d43f4ba7d750411a3b1672 Cr-Commit-Position: refs/heads/master@{#40853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M src/heap/gc-tracer.h View 4 chunks +5 lines, -9 lines 0 comments Download
M src/heap/gc-tracer.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Lippautz
4 years, 1 month ago (2016-11-09 08:58:52 UTC) #4
ulan
lgtm
4 years, 1 month ago (2016-11-09 09:49:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492433002/1
4 years, 1 month ago (2016-11-09 10:02:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 10:04:45 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:27:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d6de5f2ec25b303c7d43f4ba7d750411a3b1672
Cr-Commit-Position: refs/heads/master@{#40853}

Powered by Google App Engine
This is Rietveld 408576698