Switching getting/dismissing cards to new protocol

chrome/browser/resources/google_now/utility.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview Utility objects and functions for Google Now extension.
  * Most important entities here:
  * (1) 'wrapper' is a module used to add error handling and other services to
@@ skipping 40 matching lines @@
  * @param {string} message Diagnostic message for the case when the condition is
  *     false.
  */
 function verify(condition, message) {
   if (!condition)
     throw buildErrorWithMessageForServer('ASSERT: ' + message);
 }
 
 /**
  * Builds a request to the notification server.
+ * @param {string} method Request method.
  * @param {string} handlerName Server handler to send the request to.
- * @param {string} contentType Value for the Content-type header.
+ * @param {string=} contentType Value for the Content-type header.
  * @return {XMLHttpRequest} Server request.
  */
-function buildServerRequest(handlerName, contentType) {
+function buildServerRequest(method, handlerName, contentType) {
   var request = new XMLHttpRequest();
 
   request.responseType = 'text';
-  request.open('POST', NOTIFICATION_CARDS_URL + '/' + handlerName, true);
-  request.setRequestHeader('Content-type', contentType);
+  request.open(method, NOTIFICATION_CARDS_URL + '/' + handlerName, true);
+  if (contentType)

[robliao, 2013/10/01 21:52:43]

We should assert that the content type is allowed for the provided method. For
example, this would be disallowed with a GET.

[vadimt, 2013/10/01 22:02:46]

Such asserts could make sense in libraries that have many users. Here, it makes
more sense just to be accurate when specifying parameters to
buildServerRequest().

+    request.setRequestHeader('Content-type', contentType);
 
   return request;
 }
 
 /**
  * Sends an error report to the server.
  * @param {Error} error Error to send.
  */
 function sendErrorReport(error) {
   // Don't remove 'error.stack.replace' below!
@@ skipping 37 matching lines @@
   if (error.canSendMessageToServer)
     errorText = errorText + ': ' + error.message;
 
   var errorObject = {
     message: errorText,
     file: file,
     line: line,
     trace: filteredStack
   };
 
-  var request = buildServerRequest('jserrors', 'application/json');
+  var request = buildServerRequest('POST', 'jserrors', 'application/json');
   request.onloadend = function(event) {
     console.log('sendErrorReport status: ' + request.status);
   };
   request.send(JSON.stringify(errorObject));
 }
 
 // Limiting 1 error report per background page load.
 var errorReported = false;
 
 /**
@@ skipping 593 matching lines @@
   // Poll for the sign in state every hour.
   // One hour is just an arbitrary amount of time chosen.
   chrome.alarms.create(alarmName, {periodInMinutes: 60});
 
   return {
     addListener: addListener,
     isSignedIn: isSignedIn,
     removeToken: removeToken
   };
 }