Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2492393002: [Presentation API] Fix integration test - initial state of connection can be 'connecting' or 'conne… (Closed)

Created:
4 years, 1 month ago by zhaobin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, media-router+watch_chromium.org, mark a. foltz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] Fix integration test - initial state of connection can be 'connecting' or 'connected' presentationRequest.start().then(function(connection) { // connection state could be 'connecting' or 'connected' here }); We created two async tasks on page: 1. resolve start() and invoke callback in then(); 2. change connection state to 'connected'. It seems that execution order of these two tasks is random. Will allow both state for now. More details in crbug.com/664629 BUG=664629 Committed: https://crrev.com/8b0e9501ddf062423fd35f1ef00ba39085614dcc Cr-Commit-Position: refs/heads/master@{#431926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/test/media_router/resources/common.js View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
zhaobin
4 years, 1 month ago (2016-11-12 00:04:09 UTC) #2
mark a. foltz
4 years, 1 month ago (2016-11-12 01:16:35 UTC) #4
Lei Lei
lgtm
4 years, 1 month ago (2016-11-12 05:31:46 UTC) #5
imcheng
lgtm
4 years, 1 month ago (2016-11-14 18:52:31 UTC) #6
mark a. foltz
4 years, 1 month ago (2016-11-14 21:16:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492393002/1
4 years, 1 month ago (2016-11-14 21:17:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 22:43:23 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 22:58:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b0e9501ddf062423fd35f1ef00ba39085614dcc
Cr-Commit-Position: refs/heads/master@{#431926}

Powered by Google App Engine
This is Rietveld 408576698