Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js

Issue 2492343002: Devtools: Pretty print fix for CSS coverage decorations. (Closed)
Patch Set: Pretty print fix for CSS coverage decorations. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js b/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js
index e397119eae4b77ff588efc95f3269686d0bff4b9..9f0f5558c4d7f4edcff083346bb65de937ee87ea 100644
--- a/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js
+++ b/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js
@@ -20,7 +20,7 @@ Components.CoverageProfile = class {
/**
* @param {string} url
- * @param {!Protocol.CSS.SourceRange} range
+ * @param {!Common.TextRange} range
*/
appendUnusedRule(url, range) {
if (!url)
@@ -30,13 +30,14 @@ Components.CoverageProfile = class {
if (!uiSourceCode)
return;
- for (var line = range.startLine; line <= range.endLine; ++line)
- uiSourceCode.addLineDecoration(line, Components.CoverageProfile.LineDecorator.type, range.startColumn);
+ if (range.startColumn)
+ range.startColumn--;
+ uiSourceCode.addDecoration(range, Components.CoverageProfile.LineDecorator.type, 0);
}
reset() {
Workspace.workspace.uiSourceCodes().forEach(
- uiSourceCode => uiSourceCode.removeAllLineDecorations(Components.CoverageProfile.LineDecorator.type));
+ uiSourceCode => uiSourceCode.removeDecorationsForType(Components.CoverageProfile.LineDecorator.type));
}
};
@@ -52,16 +53,18 @@ Components.CoverageProfile.LineDecorator = class {
decorate(uiSourceCode, textEditor) {
var gutterType = 'CodeMirror-gutter-coverage';
- var decorations = uiSourceCode.lineDecorations(Components.CoverageProfile.LineDecorator.type);
+ var decorations = uiSourceCode.decorationsForType(Components.CoverageProfile.LineDecorator.type);
textEditor.uninstallGutter(gutterType);
- if (!decorations)
+ if (!decorations.size)
return;
textEditor.installGutter(gutterType, false);
- for (var decoration of decorations.values()) {
- var element = createElementWithClass('div', 'text-editor-line-marker-coverage');
- textEditor.setGutterDecoration(decoration.line(), gutterType, element);
+ for (var decoration of decorations) {
+ for (var line = decoration.range().startLine; line <= decoration.range().endLine; ++line) {
+ var element = createElementWithClass('div', 'text-editor-line-marker-coverage');
+ textEditor.setGutterDecoration(line, gutterType, element);
+ }
}
}
};

Powered by Google App Engine
This is Rietveld 408576698