Chromium Code Reviews Chromium Code Reviews
Issue 2492343002:
Devtools: Pretty print fix for CSS coverage decorations. (Closed)
| Index: third_party/WebKit/LayoutTests/inspector/tracing/decorations-after-inplace-formatter.html |
| diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/decorations-after-inplace-formatter.html b/third_party/WebKit/LayoutTests/inspector/tracing/decorations-after-inplace-formatter.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..c6a418a0b619dcb298c77ea3439b1d2c5d1bf193 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/inspector/tracing/decorations-after-inplace-formatter.html |
| @@ -0,0 +1,80 @@ |
| +<html> |
| +<head> |
| +<script src="../../http/tests/inspector/inspector-test.js"></script> |
| +<script src="../../http/tests/inspector/timeline-test.js"></script> |
| +<script src="../../http/tests/inspector/debugger-test.js"></script> |
| +<script src="../../http/tests/inspector/sources-test.js"></script> |
| + |
| +<link rel="stylesheet" type="text/css" href="resources/decorations-after-inplace-formatter.css"> |
| +<script> |
| + |
| +function test() |
| +{ |
| + Runtime.experiments.enableForTest("timelineRuleUsageRecording"); |
| + |
| + var panel = UI.panels.timeline; |
| + panel._markUnusedCSS.set(true); |
| + |
| + var scriptFormatter; |
| + |
| + InspectorTest.startTimeline(timelineStarted); |
| + |
| + function timelineStarted() |
| + { |
| + InspectorTest.stopTimeline(onTracingFinished); |
| + } |
| + |
| + function onTracingFinished() |
| + { |
| + UI.inspectorView.showPanel("sources").then(formatterSetup); |
| + } |
| + function formatterSetup() |
| + { |
| + inplaceFormatter().then(function(sf) { |
| + scriptFormatter = sf; |
| + showSource(); |
| + }); |
| + } |
| + function showSource() |
| + { |
| + InspectorTest.showScriptSource("decorations-after-inplace-formatter.css", showDecorations); |
| + } |
| + function showDecorations() |
| + { |
| + InspectorTest.addSniffer(Components.CoverageProfile.LineDecorator.prototype, "decorate", formatSource); |
|
caseq
2016/11/17 22:13:19
So when "decorate" is invoked? Looks like a race s
|
| + } |
| + |
| + function formatSource(frame) |
| + { |
| + InspectorTest.addSniffer(Components.CoverageProfile.LineDecorator.prototype, "decorate", uiSourceCodeScriptFormatted); |
| + scriptFormatter._formatSourceInPlace(); |
| + } |
| + |
| + function uiSourceCodeScriptFormatted() |
| + { |
| + var lines = Array.prototype.map.call(document.querySelectorAll(".text-editor-line-marker-coverage"), |
| + e => e.parentElement.previousSibling.textContent); |
| + |
| + InspectorTest.addResult("Formatted line numbers of rules that were not used:"); |
| + InspectorTest.addResult(lines); |
| + InspectorTest.completeTest(); |
| + } |
| + |
| + function inplaceFormatter() |
| + { |
| + return self.runtime.allInstances(Sources.SourcesView.EditorAction).then(function(editorActions) { |
| + for (var i = 0; i < editorActions.length; ++i) { |
| + if (editorActions[i] instanceof Sources.InplaceFormatterEditorAction) |
| + return editorActions[i]; |
| + } |
| + return null; |
| + }); |
| + } |
| +} |
| +</script> |
| +</head> |
| +<p id="id">PASS</p> |
| +<body onload="runTest()"> |
| +<p>Tests the CSS highlight in sources after the Pretty print formatting.</p> |
| +</body> |
| +</html> |
