Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2492293002: [MD Settings][Options] Fixes bugs with the sync status messages/actions (Closed)

Created:
4 years, 1 month ago by Moe
Modified:
4 years, 1 month ago
Reviewers:
maxbogue, Dan Beam, tommycli
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings][Options] Fixes bugs with the sync status messages/actions 1. Fixes a wrong callback handler name in the MD settings page. 2. Updates the old settings page to handle the new more-precise sync error states that were implemented for MD Settings. screenshots: https://screenshot.googleplex.com/2Ob1e23X9z7 https://screenshot.googleplex.com/SQ4vjNAxqbf https://screenshot.googleplex.com/sN6FakgQPn9 https://screenshot.googleplex.com/uaeNOf9ukx2 BUG=663505 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737 Cr-Commit-Position: refs/heads/master@{#432928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -19 lines) Patch
M chrome/browser/resources/options/browser_options.js View 2 chunks +25 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/sync_setup_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 6 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (20 generated)
Moe
Hi Dan, Max, Please review this CL.
4 years, 1 month ago (2016-11-14 15:20:13 UTC) #14
maxbogue
sync lgtm
4 years, 1 month ago (2016-11-14 21:29:58 UTC) #17
Dan Beam
+tommycli@ for first pass (I think he'll be a more useful reviewer) I can do ...
4 years, 1 month ago (2016-11-15 02:48:51 UTC) #19
Moe
On 2016/11/15 02:48:51, Dan Beam wrote: > +tommycli@ for first pass (I think he'll be ...
4 years, 1 month ago (2016-11-16 18:36:05 UTC) #20
tommycli
lgtm these changes look harmless. One suggestion: please update the CL description to explain the ...
4 years, 1 month ago (2016-11-16 19:19:01 UTC) #21
Dan Beam
lgtm
4 years, 1 month ago (2016-11-16 19:22:54 UTC) #22
Dan Beam
oh, there needs to be a period between the second sentence and the "Sign in ...
4 years, 1 month ago (2016-11-16 19:26:28 UTC) #23
Moe
On 2016/11/16 19:26:28, Dan Beam wrote: > oh, there needs to be a period between ...
4 years, 1 month ago (2016-11-17 15:38:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492293002/40001
4 years, 1 month ago (2016-11-17 15:38:24 UTC) #27
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 1 month ago (2016-11-17 18:52:38 UTC) #29
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:28:26 UTC) #31
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737
Cr-Commit-Position: refs/heads/master@{#432928}

Powered by Google App Engine
This is Rietveld 408576698