[MD Settings][Options] Fixes bugs with the sync status messages/actions

[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Fixes a wrong callback handler name in the MD settings page.
2. Updates the old settings page to handle the new more-precise sync error states that were implemented for MD Settings.

screenshots:
https://screenshot.googleplex.com/2Ob1e23X9z7
https://screenshot.googleplex.com/SQ4vjNAxqbf
https://screenshot.googleplex.com/sN6FakgQPn9
https://screenshot.googleplex.com/uaeNOf9ukx2

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737
Cr-Commit-Position: refs/heads/master@{#432928}

[Moe, 2016-11-11 19:39:07]

Description was changed from

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Wrong callback-handler pair in MD settings and old settings.
2. Some messages were missing action links in the old settings.
2. Wrong actions for some messages in the old settings.

BUG=663505
==========

to

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Wrong callback-handler pair in MD settings and old settings.
2. Some messages were missing action links in the old settings.
2. Wrong actions for some messages in the old settings.

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-11-11 19:39:11]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 19:39:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:00:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:00:30]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Moe, 2016-11-14 15:07:35]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 15:07:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-11-14 15:08:17]

Patchset #1 (id:1) has been deleted

[Moe, 2016-11-14 15:18:35]

Description was changed from

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Wrong callback-handler pair in MD settings and old settings.
2. Some messages were missing action links in the old settings.
2. Wrong actions for some messages in the old settings.

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Fixes a wrong callback handler name in the MD settings page.
2. Adds action links for some of the status messages that were missing them
(used in the old settings page only).
3. Correctly handles the acions in the old settings page.

screenshots:
https://screenshot.googleplex.com/2Ob1e23X9z7
https://screenshot.googleplex.com/SQ4vjNAxqbf
https://screenshot.googleplex.com/sN6FakgQPn9
https://screenshot.googleplex.com/uaeNOf9ukx2

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-11-14 15:19:12]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[Moe, 2016-11-14 15:19:21]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-14 15:19:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-11-14 15:20:12]

mahmadi@chromium.org changed reviewers:
+ dbeam@chromium.org, maxbogue@chromium.org

[Moe, 2016-11-14 15:20:13]

Hi Dan, Max,

Please review this CL.

[commit-bot: I haz the power, 2016-11-14 16:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 16:17:41]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-11-14 21:29:58]

sync lgtm

[Dan Beam, 2016-11-15 02:48:24]

dbeam@chromium.org changed reviewers:
+ tommycli@chromium.org

[Dan Beam, 2016-11-15 02:48:51]

+tommycli@ for first pass (I think he'll be a more useful reviewer)

I can do owners for old options/ when tommycli@'s happy

[Moe, 2016-11-16 18:36:05]

On 2016/11/15 02:48:51, Dan Beam wrote:
> +tommycli@ for first pass (I think he'll be a more useful reviewer)
> 
> I can do owners for old options/ when tommycli@'s happy

tommycli@ could you please take a look at this before the branch point? Thank
you.

[tommycli, 2016-11-16 19:19:01]

lgtm these changes look harmless.

One suggestion: please update the CL description to explain the general theme of
these changes (updating Old Options to handle the new more-precise sync error
states that were implemented for MD Settings).

Thanks,

Tommy

[Dan Beam, 2016-11-16 19:22:54]

lgtm

[Dan Beam, 2016-11-16 19:26:28]

oh, there needs to be a period between the second sentence and the "Sign in
again" link

[Moe, 2016-11-17 14:42:36]

Description was changed from

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Fixes a wrong callback handler name in the MD settings page.
2. Adds action links for some of the status messages that were missing them
(used in the old settings page only).
3. Correctly handles the acions in the old settings page.

screenshots:
https://screenshot.googleplex.com/2Ob1e23X9z7
https://screenshot.googleplex.com/SQ4vjNAxqbf
https://screenshot.googleplex.com/sN6FakgQPn9
https://screenshot.googleplex.com/uaeNOf9ukx2

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Fixes a wrong callback handler name in the MD settings page.
2. Updates the old settings page to handle the new more-precise sync error
states that were implemented for MD Settings.

screenshots:
https://screenshot.googleplex.com/2Ob1e23X9z7
https://screenshot.googleplex.com/SQ4vjNAxqbf
https://screenshot.googleplex.com/sN6FakgQPn9
https://screenshot.googleplex.com/uaeNOf9ukx2

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-11-17 15:38:05]

On 2016/11/16 19:26:28, Dan Beam wrote:
> oh, there needs to be a period between the second sentence and the "Sign in
> again" link

dbeam@ I followed up with bettes@ about the punctuation (you're CC'd).
tommycli@, following up on our offline conversation, "Enter passphrase" appears
on the next line because of the max-width of the settings sections and because
of its margin it looks off. Like you said, since this is mostly a functional fix
i'll go ahead and land it. We can work on the aesthetics in a follow up patch if
necessary. Thank you.

[Moe, 2016-11-17 15:38:10]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2016-11-17 15:38:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 18:52:36]

Description was changed from

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Fixes a wrong callback handler name in the MD settings page.
2. Updates the old settings page to handle the new more-precise sync error
states that were implemented for MD Settings.

screenshots:
https://screenshot.googleplex.com/2Ob1e23X9z7
https://screenshot.googleplex.com/SQ4vjNAxqbf
https://screenshot.googleplex.com/sN6FakgQPn9
https://screenshot.googleplex.com/uaeNOf9ukx2

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Fixes a wrong callback handler name in the MD settings page.
2. Updates the old settings page to handle the new more-precise sync error
states that were implemented for MD Settings.

screenshots:
https://screenshot.googleplex.com/2Ob1e23X9z7
https://screenshot.googleplex.com/SQ4vjNAxqbf
https://screenshot.googleplex.com/sN6FakgQPn9
https://screenshot.googleplex.com/uaeNOf9ukx2

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-17 18:52:38]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-11-17 20:28:24]

Description was changed from

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Fixes a wrong callback handler name in the MD settings page.
2. Updates the old settings page to handle the new more-precise sync error
states that were implemented for MD Settings.

screenshots:
https://screenshot.googleplex.com/2Ob1e23X9z7
https://screenshot.googleplex.com/SQ4vjNAxqbf
https://screenshot.googleplex.com/sN6FakgQPn9
https://screenshot.googleplex.com/uaeNOf9ukx2

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings][Options] Fixes bugs with the sync status messages/actions

1. Fixes a wrong callback handler name in the MD settings page.
2. Updates the old settings page to handle the new more-precise sync error
states that were implemented for MD Settings.

screenshots:
https://screenshot.googleplex.com/2Ob1e23X9z7
https://screenshot.googleplex.com/SQ4vjNAxqbf
https://screenshot.googleplex.com/sN6FakgQPn9
https://screenshot.googleplex.com/uaeNOf9ukx2

BUG=663505
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737
Cr-Commit-Position: refs/heads/master@{#432928}
==========

[commit-bot: I haz the power, 2016-11-17 20:28:26]

Patchset 1 (id:??) landed as
https://crrev.com/7d0d4287db7ff0d694e1695bb640c1cb0a29e737
Cr-Commit-Position: refs/heads/master@{#432928}