GN: Always check for bad items.

tools/gn/command_args.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include <map>
@@ skipping 100 matching lines @@
     GetContextForValue(value, &location, &comment);
     OutputString("    " + location + "\n" + comment);
   } else {
     OutputString("    (Internally set; try `gn help " + name.as_string() +
                  "`.)\n");
   }
 }
 
 int ListArgs(const std::string& build_dir) {
   Setup* setup = new Setup;
-  setup->build_settings().set_check_for_bad_items(false);
   if (!setup->DoSetup(build_dir, false) || !setup->Run())
     return 1;
 
   Scope::KeyValueMap build_args;
   setup->build_settings().build_args().MergeDeclaredArguments(&build_args);
 
   // Find all of the arguments we care about. Use a regular map so they're
   // sorted nicely when we write them out.
   std::map<base::StringPiece, Value> sorted_args;
   std::string list_value =
@@ skipping 92 matching lines @@
   return system(cmd.c_str()) == 0;
 }
 
 #endif
 
 int EditArgsFile(const std::string& build_dir) {
   {
     // Scope the setup. We only use it for some basic state. We'll do the
     // "real" build below in the gen command.
     Setup setup;
-    setup.build_settings().set_check_for_bad_items(false);

[brettw, 2016/11/11 18:21:49]

This is the only non-introspection disabling of the checking. But DoSetup
doesn't do any checking anyway (the build is not run in this case), so the flag
is not used.

     // Don't fill build arguments. We're about to edit the file which supplies
     // these in the first place.
     setup.set_fill_arguments(false);
     if (!setup.DoSetup(build_dir, true))
       return 1;
 
     // Ensure the file exists. Need to normalize path separators since on
     // Windows they can come out as forward slashes here, and that confuses some
     // of the commands.
     base::FilePath arg_file =
@@ skipping 100 matching lines @@
         "Or see \"gn help args\" for more variants.").PrintToStdout();
     return 1;
   }
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(kSwitchList))
     return ListArgs(args[0]);
   return EditArgsFile(args[0]);
 }
 
 }  // namespace commands