Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: src/heap/mark-compact-inl.h

Issue 2492263002: [heap] Add atomics to mark bit operations. (Closed)
Patch Set: fixup missing call sites Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/mark-compact-inl.h
diff --git a/src/heap/mark-compact-inl.h b/src/heap/mark-compact-inl.h
index 8861241df019528d05de4fc849cb6b68f3d59969..62778cd5770d0f9b49fb2812172f1dd2c3277350 100644
--- a/src/heap/mark-compact-inl.h
+++ b/src/heap/mark-compact-inl.h
@@ -14,9 +14,9 @@ namespace internal {
template <MarkingMode mode>
void MarkCompactCollector::PushBlack(HeapObject* obj) {
- DCHECK(ObjectMarking::IsBlack<mode>(obj));
+ DCHECK((ObjectMarking::IsBlack<MarkBit::NON_ATOMIC, mode>(obj)));
if (!marking_deque<mode>()->Push(obj)) {
- ObjectMarking::BlackToGrey<mode>(obj);
+ ObjectMarking::BlackToGrey<MarkBit::NON_ATOMIC, mode>(obj);
}
}
@@ -30,8 +30,8 @@ void MarkCompactCollector::UnshiftBlack(HeapObject* obj) {
template <MarkingMode mode>
void MarkCompactCollector::MarkObject(HeapObject* obj) {
- if (ObjectMarking::IsWhite<mode>(obj)) {
- ObjectMarking::WhiteToBlack<mode>(obj);
+ if (ObjectMarking::IsWhite<MarkBit::NON_ATOMIC, mode>(obj)) {
+ ObjectMarking::WhiteToBlack<MarkBit::NON_ATOMIC, mode>(obj);
PushBlack<mode>(obj);
}
}

Powered by Google App Engine
This is Rietveld 408576698